-
Notifications
You must be signed in to change notification settings - Fork 9.4k
inserted image in product description got broken on front end #6138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Please, format this issue according to the Issue reporting guidelines: with steps to reproduce, actual result and expected result. |
PreconditionsUsing custom Ubuntu xenial vagrant-box, php7, apache
Steps to reproduce
Expected resultImage gets rendered in the description area Actual resultImage is not rendered, instead you get broken image link icon NotesWhat I have now experienced is that the media directive in product description never gets converted to the common format of {{media}}. Instead, it remains an admin link. This means that it kind of looks OK for you after you have saved it and remain logged in in admin, but as soon as you log out or as soon as someone else visits the product page - the image link is broken. Seems that same happens with category description. Even if you try to use media directives, they never get converted to proper image url's. Issue prevalent: product pages, category pages. |
The actual URL generated in the frontend for the image is similar to:
Accessing the url directly redirects you to the admin dashboard (if logged in). |
Internal ticket ->MAGETWO-57796 has been created for this issue. Thank you for the detailed bug report. |
Same problem as @allanpaiste. Revealing admin url is a security issue:
We have a lot of product descriptions which show a broken image and it happens only when administrator log's out from Magento admin. This should be high priority. |
Bugs: * MAGETWO-57796: [GitHub] Inserted image in product description got broken on front end #6138 * MAGETWO-54253: Export filters for products do not work
Hi @forvin This issue was fixed in develop branch and will be ported to 2.1.x branch. |
@shiftedreality is there a timetable for when it will be ported over to the 2.1.x branch? |
Hi @ferrarinim. Please re-edit your product description, because you have corrupted data in your DB. |
Hi @shiftedreality... I've tried but after some time the image disappears... |
I've update two files setup.js and Eav.php |
@shiftedreality , @mmansoorebay |
@treestonemedia: scroll up a little bit to the comment from @Talv, he mentions a small extension which might fix this. @okorshenko: are there already plans to backport MAGETWO-57796 and MAGETWO-66885 to 2.1.x? If not, I'll try creating a PR for this. |
…ken on front end magento#6138 (cherry picked from commit a657749) MAGETWO-57796: [GitHub] Inserted image in product description got broken on front end magento#6138 (cherry picked from commit e3d67ea) MAGETWO-57796: [GitHub] Inserted image in product description got broken on front end magento#6138 (cherry picked from commit 228ee3a) MAGETWO-57796: [GitHub] Inserted image in product description got broken on front end magento#6138 (cherry picked from commit 9030e08)
OK so i tried the sulotion by @Talv and it breaks the images becuase it just inserts this into the html |
…ption got broken on front end #6138 - for 2.1
Hi @hostep |
Nice job @okorshenko, this is another huge step forwards in better communicating to the community about what is happening internally, very happy to see this happening! If I may, some other things you might consider:
I already mentioned these things a couple of times in the past, but I don't think it hurts to remind you guys about this. Anyway, I don't want to complain too much, we've seen huge leaps forwards since the beginning of 2017 about communicating towards the community, so big applause for that 👏 👍 (Also big thanks to @korostii, I think his comments have helped to accomplish this new step forwards as well.) |
Internal ticket to track issue progress: MAGETWO-70435 |
@forvin, thank you for your report. |
Issue still exists in Magento 2.2.0. |
@kenmaxnejp: yes indeed, but the cause of the bug is different this time. The new bug should get fixed by 6237877. I believe the fix is scheduled to be part of Magento 2.2.2 which should get released by the end of this year from what I've heard. |
@hostep Thanks for the update. I confirmed the fix 6237877 works in Magento 2.2.0. I posted those images all over again after I edited the file and it works. Actually I cannot find app/code/Magento/Cms/Helper/Wysiwyg/Images.php, so I edited vendor/magento/module-cms/Helper/Wysiwyg/Images.php instead. |
How to solve this error in Magento 2.1.8 version? Please help us if anyone know. |
How to solve this error in Magento 2.1.8 version? Please help us if anyone know. |
@Vishrootways: update to a newer version of Magento, it was fixed in 2.1.9 or 2.1.10 if I remember correctly. |
Hi @hostep thank you. Is there any patch to solve this issue in 2.1.8? |
We are getting this issue in magento version 2.2.2 and 2.2.3. Any solution? |
@pradeepnew or @Vishrootways: can you open a new issue with the exact steps to reproduce this on a clean installation, that would be really appreciated! |
I am having very similar issue (just not on product description) on 2.3.1...... 🤦♂️ |
[TSG-CSL3] For 2.3.7-develop (MC-37104)
My site is built by Magento 2.1. Newly added products will not appear until you manually re-index via SSH. But inserted image in product description will break after you re-index your magento. Anybody know how to fix the two problems? Thank you !
The text was updated successfully, but these errors were encountered: