Skip to content

Solution for Magento 2.2.0: Translations for 'Item in Cart' in mini cart missing. #12109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Solution for Magento 2.2.0: Translations for 'Item in Cart' in mini cart missing. #12109

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Nov 8, 2017 •
edited by ghost
Loading

Description

A solution for Magento 2.2.0: Translations for 'Item in Cart' in mini cart missing.

Fixed Issues (if relevant)

  1. Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart. #12081: Magento 2.2.0: Translations for 'Item in Cart' missing in mini cart.

Manual testing scenarios

  1. Add one item on a cart and check translate on the mini cart.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 8, 2017 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added 2.2.x Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Nov 8, 2017
@okorshenko okorshenko self-assigned this Nov 10, 2017
@okorshenko okorshenko added this to the November 2017 milestone Nov 10, 2017
@okorshenko
Copy link
Contributor

Hi @emiprotech thank you for your contribution. Unfortunately, this code change does not fix the linked issue. I'm closing this pull request for now. If you would like to update, please, reopen the PR
Thank you

@okorshenko okorshenko closed this Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@okorshenko okorshenko

Labels
Release Line: 2.2 Reproduced on 2.2.x The issue has been reproduced on latest 2.2 release Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
November 2017
Development

Successfully merging this pull request may close these issues.
4 participants
@magento-cicd2 @okorshenko @magento-engcom-team @mayankzalavadia