2.3 only - creating attribute option value using API returns unexpected response #18392 #19108
Conversation
|
Hi @Nazar65. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
|
Hi @VladimirZaets, thank you for the review. |
…attribute-option-value
| \Magento\Eav\Model\ResourceModel\Entity\Attribute $resourceModel | ||
| AttributeRepository $attributeRepository, | ||
| Attribute $resourceModel, | ||
| GetAttributeOptionId $getAttributeOptionId |
There was a problem hiding this comment.
Please, inject new dependencies according to our Backward Compatible Development Guide
|
Hi @sidolov all done. |
| @@ -14,6 +14,7 @@ | |||
| use Magento\Framework\Exception\InputException; | |||
| use Magento\Framework\Exception\NoSuchEntityException; | |||
| use Magento\Framework\Exception\StateException; | |||
| use \Magento\Framework\App\ObjectManager; | |||
There was a problem hiding this comment.
The first \ can be removed here so it's consistent with the use statements above it.
There was a problem hiding this comment.
@hostep Thanks for some reason I did not see it right away
remove "\" from use Object Manager
|
after some changes in 2.3-develop now we have "returned id of option". So no need anymore this PR. Created at on Nov 7, 2018 😕 |
|
Hi @Nazar65, thank you for your contribution! |
ghost
mentioned this pull request
Description (*)
Return value should be the ID of the new option
Fixed Issues (if relevant)
Manual testing scenarios (*)
curl -k -X POST "https://domain.tld/rest/all/V1/products/attributes/dropdown/options" -H "accept: application/json" -H "Content-Type: application/json" -H "Authorization: Bearer abcd" -d "{ \"option\": { \"label\": \"whatever\" }}Contribution checklist (*)