-
Notifications
You must be signed in to change notification settings - Fork 9.4k
fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field. #22697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field. #22697
Conversation
fixed param issue
change int to string
Hi @GovindaSharma. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
@magento-engcom-team hello, is there any progress on this issue yet ? |
@magento-engcom-team give me test instance |
Hi @sdzhepa. Thank you for your request. I'm working on Magento instance for you |
Hi @sdzhepa, here is your new Magento instance. |
@magento run all tests |
Hey @GovindaSharma please fix the failing tests - Functional and WebAPI. YOu can ignore Database Compare. Also we need to have all fixes covered with automated tests. WebAPI is appropriate here |
@magento run Database Compare build |
@@ -15,7 +15,7 @@ interface BillingAddressManagementInterface | |||
/** | |||
* Assigns a specified billing address to a specified cart. | |||
* | |||
* @param int $cartId The cart ID. | |||
* @param string $cartId The cart ID. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cart id should be int instead of string.
@GovindaSharma , I am closing this PR now due to inactivity. |
Hi @GovindaSharma, thank you for your contribution! |
fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.
Description (*)
fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.
Fixed Issues (if relevant)
fixed issue #7299 V1/carts/mine/billing-address returning %fieldName is a required field.
Manual testing scenarios (*)
Preconditions
Magento EE 2.1.1
PHP 7.0.12
Mysql Ver 14.14 Distrib 5.6.33-79.0, for Linux (x86_64) using 6.2
Steps to reproduce
Go to the checkout after adding something to the basket
Send a request to the REST endpoint V1/carts/mine/billing-address using the payload below
{"cartId":"190488","address":{"countryId":"GB","regionId":"0","region":"","street":["54 Carnegie Court",""],"company":"","telephone":"0165 4569 8754","fax":"","postcode":"AB1C 2DF","city":"SomeCity","firstname":"Bob","lastname":"White","save_in_address_book":1,"saveInAddressBook":null}}
Contribution checklist (*)