No alert when user "Apply empty Coupon Code" in create new order form (issue 24015)

[edenduong]

Description (*)

1. Resolve No alert when user "Apply empty Coupon Code" in create new order form #24015: No alert when user "Apply empty Coupon Code" in create new order form

Solution: Use alert modal in the case no coupon code.

Fixed Issues (if relevant)

1. No alert when user "Apply empty Coupon Code" in create new order form #24015: No alert when user "Apply empty Coupon Code" in create new order form

Manual testing scenarios (*)

1. Go to backend
2. Sales->Orders->Create New Order
3. Choose Customer, go to the Create New Order form
4. Add some product to cart
5. Click "Apply Coupon Code" without filling the field.

Expected result

1. Alert the notification

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @edenduong. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[rogyar]

@magento give me test instance

[magento-engcom-team]

Hi @rogyar. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @rogyar, here is your new Magento instance.
Admin access: https://pr-24016.instances.magento-community.engineering/admin
Login: admin Password: 123123q

[rogyar]

Hi @edenduong. Thank you for the improvement!

[magento-engcom-team]

Hi @rogyar, thank you for the review.
ENGCOM-5552 has been created to process this Pull Request

[engcom-Delta]

Hi @edenduong those changes produce new issue with coupon code: coupon code cannot be removed when click on Remove Coupon Code icon
Manual testing scenario:

• Create Cart Price Rule with coupon code
• Create simple product
• Create customer
• Go Sales->Orders->Create New Order
• Choose customer
• Add simple product
• Enter valid coupon code to Apply Coupon Code filed and click Apply icon
• Now click on Remove Coupon Code icon
• ❌ Alert notification "Attention Please enter a coupon code!" is shown and coupon code cannot be removed
  

[edenduong]

@engcom-Delta: I am sorry about that. I have resolved it, you can check it again.
@rogyar: Please review my changes.

Thank you!

[edenduong]

@rogyar: Could you please review my new changes?

[magento-engcom-team]

Hi @sidolov, thank you for the review.
ENGCOM-5552 has been created to process this Pull Request

[engcom-Delta]

✔️ QA passed

[m2-assistant]

Hi @edenduong, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.