24025 add caching for magento product version

[davidverholen]

fixes #24025

Description (*)

add caching for product version, to not utilize composer runtime on every request to the magento product version.

While this method is called rarely in the core, many 3rd party extensions rely on it to determine the magento version. This leads to many "real" projects having >100ms added to non cached requests

Fixed Issues (if relevant)

1. Slow Performance of ProductMetadata::getVersion #24025

Manual testing scenarios (*)

1. have a module installed that relies on the product version to determine e.g. feature compatibility
2. profile uncached requests

Questions or comments

Contribution checklist (*)

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @davidverholen. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

[torhoehn]

@davidverholen Please fix failing tests. :)

[davidverholen]

@torhoehn do you have an idea why the database compare build fails? Results seem to be all green but still the check is failing

[torhoehn]

@davidverholen It's just a problem with the infrastructure. Seems okay for me. :)

[magento-engcom-team]

Hi @torhoehn, thank you for the review.
ENGCOM-5554 has been created to process this Pull Request
✳️ @torhoehn, could you please add one of the following labels to the Pull Request?

Label	Description
Auto-Tests: Covered	All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered	Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required	Changes in Pull Request does not require coverage by auto-tests

[m2-assistant]

Hi @davidverholen, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

[ihor-sviziev]

Test coverage was added in #26001