Improvement PageLayout Config Builder. Added save in cache config files. #28818

Knase · 2020-06-20T00:44:25Z

Description (*)

Magento often runs getPageLayoutsConfig. I added to save in cache config files. This optimization will be reduced load time.

Related Pull Requests

Fixed Issues (if relevant)

Fixes magento/magento2#<issue_number>

Manual testing scenarios (*)

...
...

Questions or comments

Contribution checklist (*)

Pull request has a meaningful description of its purpose
All commits are accompanied by meaningful commit messages
All new or changed code is covered with unit/integration tests (if applicable)
All automated tests passed successfully (all builds are green)

Resolved issues:

resolves [Issue] Improvement PageLayout Config Builder. Added save in cache config files. #29546: Improvement PageLayout Config Builder. Added save in cache config files.

m2-assistant · 2020-06-20T00:44:27Z

Hi @Knase. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

@magento give me test instance - deploy test instance based on PR changes
@magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

@magento run all tests - run or re-run all required tests against the PR changes
@magento run <test-build(s)> - run or re-run specific test build(s)
For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

Database Compare
Functional Tests CE
Functional Tests EE,
Functional Tests B2B
Integration Tests
Magento Health Index
Sample Data Tests CE
Sample Data Tests EE
Sample Data Tests B2B
Static Tests
Unit Tests
WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

m2-assistant · 2020-06-22T18:38:06Z

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-assistant · 2020-06-22T18:38:32Z

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

m2-assistant · 2020-06-23T20:25:45Z

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Knase · 2020-06-25T10:54:14Z

@magento give me 2.4-develop instance

magento-engcom-team · 2020-06-25T10:54:19Z

Hi @Knase. Thank you for your request. I'm working on Magento 2.4-develop instance for you

magento-engcom-team · 2020-06-25T10:55:46Z

Hi @Knase, here is your Magento instance.
Admin access: https://i-28818-2-4-develop.instances.magento-community.engineering/admin_f300
Login: b7bd962e Password: 8912a59ae74b
Instance will be terminated in up to 3 hours.

Knase · 2020-06-25T11:26:45Z

@magento run all tests

sidolov · 2020-08-14T20:15:15Z

@magento create issue

sidolov

Hi @Knase! Nice finding, usually caching the repeatable operations can significantly improve performance but sometimes it looks almost the same time as without cache. Do you have any performance measurements for both cases: with and without the cache? Thank you!

Knase · 2020-08-21T10:41:07Z

Hi @sidolov, we used this improvement at 2.1-2.2 client Magento projects. I will take performance measurements at the latest Magento version and give them.

sidolov · 2020-09-03T19:12:41Z

@Knase do you have any updates on the PR? Thanks!

engcom-Echo · 2020-09-09T09:38:23Z

Hi, @Knase. Please can you fix fail tests?

engcom-Echo · 2020-09-10T11:12:18Z

@magento run all tests

engcom-Echo · 2020-09-11T09:23:23Z

@magento run all tests

magento-engcom-team · 2020-09-14T10:26:07Z

Hi @gabrieldagama, thank you for the review.
ENGCOM-8195 has been created to process this Pull Request
✳️ @gabrieldagama, could you please add one of the following labels to the Pull Request?

Label	Description
`Auto-Tests: Covered`	All changes in Pull Request is covered by auto-tests
`Auto-Tests: Not Covered`	Changes in Pull Request requires coverage by auto-tests
`Auto-Tests: Not Required`	Changes in Pull Request does not require coverage by auto-tests

engcom-Echo · 2020-09-22T10:23:48Z

✔️ QA passed
Result:

❌ Before:

✔️ After:

Tested protected function getConfigFiles().
On test used delay "usleep(100);", otherwise, the values time is very meager.

…he config files. #28818

m2-assistant · 2020-09-23T12:33:37Z

Hi @Knase, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

Improvement PageLayout Config Builder. Added save in cache config files.

f2468b5

ghost added the Progress: pending review label Jun 20, 2020

magento-engcom-team added Component: Theme Release Line: 2.4 labels Jun 20, 2020

Merge branch '2.4-develop' into cache-config-builder

cc2c5b9

Knase closed this Jun 22, 2020

Knase reopened this Jun 22, 2020

Knase closed this Jun 22, 2020

Knase reopened this Jun 22, 2020

Merge branch '2.4-develop' into cache-config-builder

26b41af

Knase closed this Jun 23, 2020

Knase reopened this Jun 23, 2020

Merge branch '2.4-develop' into cache-config-builder

eeecdf7

m2-assistant bot mentioned this pull request Aug 14, 2020

[Issue] Improvement PageLayout Config Builder. Added save in cache config files. #29546

Closed

4 tasks

sidolov added Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Priority: P2 A defect with this priority could have functionality issues which are not to expectations. labels Aug 14, 2020

sidolov requested changes Aug 19, 2020

View reviewed changes

ghost assigned sidolov Aug 19, 2020

ghost added Progress: needs update and removed Progress: pending review labels Aug 19, 2020

sidolov added the Partner: Guidance Solutions label Aug 21, 2020

engcom-Echo self-assigned this Sep 9, 2020

Merge branch '2.4-develop' into cache-config-builder

2ac6e0c

engcom-Echo requested a review from sidolov September 10, 2020 11:38

failing tests fixed

276cb1c

engcom-Echo force-pushed the cache-config-builder branch from aa44171 to 276cb1c Compare September 11, 2020 09:23

gabrieldagama approved these changes Sep 14, 2020

View reviewed changes

ghost assigned gabrieldagama Sep 14, 2020

ghost added Progress: ready for testing and removed Progress: needs update labels Sep 14, 2020

magento-engcom-team added the partners-contribution Pull Request is created by Magento Partner label Sep 14, 2020

ghost added Progress: testing in progress and removed Progress: ready for testing labels Sep 22, 2020

ghost added Progress: extended testing and removed Progress: testing in progress labels Sep 22, 2020

engcom-Echo added the QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) label Sep 22, 2020

engcom-Alfa added QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope and removed QA: Ready to add to Regression Scope Should be analyzed and added to Regression Testing Scope(if applicable) labels Sep 22, 2020

ghost added Progress: accept and removed Progress: extended testing labels Sep 22, 2020

magento-engcom-team pushed a commit that referenced this pull request Sep 23, 2020

ENGCOM-8195: Improvement PageLayout Config Builder. Added save in cac…

c9a4107

…he config files. #28818

magento-engcom-team merged commit e877544 into magento:2.4-develop Sep 23, 2020

sidolov added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Sep 23, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improvement PageLayout Config Builder. Added save in cache config files. #28818

Improvement PageLayout Config Builder. Added save in cache config files. #28818

Knase commented Jun 20, 2020 •

edited by m2-assistant bot

Loading

m2-assistant bot commented Jun 20, 2020

m2-assistant bot commented Jun 22, 2020

m2-assistant bot commented Jun 22, 2020

m2-assistant bot commented Jun 23, 2020

Knase commented Jun 25, 2020

magento-engcom-team commented Jun 25, 2020

magento-engcom-team commented Jun 25, 2020

Knase commented Jun 25, 2020

sidolov commented Aug 14, 2020

sidolov left a comment

Knase commented Aug 21, 2020

sidolov commented Sep 3, 2020

engcom-Echo commented Sep 9, 2020

engcom-Echo commented Sep 10, 2020

engcom-Echo commented Sep 11, 2020

magento-engcom-team commented Sep 14, 2020

engcom-Echo commented Sep 22, 2020

m2-assistant bot commented Sep 23, 2020

Improvement PageLayout Config Builder. Added save in cache config files. #28818

Improvement PageLayout Config Builder. Added save in cache config files. #28818

Conversation

Knase commented Jun 20, 2020 • edited by m2-assistant bot Loading

Description (*)

Related Pull Requests

Fixed Issues (if relevant)

Manual testing scenarios (*)

Questions or comments

Contribution checklist (*)

Resolved issues:

m2-assistant bot commented Jun 20, 2020

m2-assistant bot commented Jun 22, 2020

m2-assistant bot commented Jun 22, 2020

m2-assistant bot commented Jun 23, 2020

Knase commented Jun 25, 2020

magento-engcom-team commented Jun 25, 2020

magento-engcom-team commented Jun 25, 2020

Knase commented Jun 25, 2020

sidolov commented Aug 14, 2020

sidolov left a comment

Choose a reason for hiding this comment

Knase commented Aug 21, 2020

sidolov commented Sep 3, 2020

engcom-Echo commented Sep 9, 2020

engcom-Echo commented Sep 10, 2020

engcom-Echo commented Sep 11, 2020

magento-engcom-team commented Sep 14, 2020

engcom-Echo commented Sep 22, 2020

m2-assistant bot commented Sep 23, 2020

Knase commented Jun 20, 2020 •

edited by m2-assistant bot

Loading