Bad tax calculation function #477
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On this file app/code/Magento/Catalog/view/adminhtml/catalog/product/js.phtml on line 73 I think there is an error when calculating the tax rate, this should read ```php spanValue = ' ' + formatCurrency((input.value/100)*rate, priceFormat);``` instead of ```php spanValue = ' ' + formatCurrency(input.value/(100+rate)*rate, priceFormat);``` The problem is adding rate to 100(%). This is present on current Magento EE 1.13 and Magento CE.
|
@centerax , thank you for your contribution! We will review your suggested code change and will let you know once we have the results. |
|
@centerax, thanks for the input. Looks like an issue - I've put a ticket in for the team to address in M2, plus a separate ticket to address in 1.x. |
|
Thanks for the update Chuck. |
|
Hi @centerax, my bad this does not appear to be an issue when coupled with our tax rate logic; turns out making this change breaks a number of our automated tax tests. I'm closing this as won't fix. Our current plan calls for ramping up a team in a couple months to start porting over 1.13.2 tax engine ( not released yet ) to M2. |
magento-team
pushed a commit
that referenced
this pull request
Jul 17, 2015
MAGETWO-40183 Accept 9 Public Pull Requests
magento-team
pushed a commit
that referenced
this pull request
Mar 24, 2016
[South] Configurable Product Improvements
okorshenko
pushed a commit
that referenced
this pull request
Dec 14, 2016
Fixed issues: - MAGETWO-58320: Eliminate Slow Query for Media Gallery data - MAGETWO-59398: [Cloud] Custom theme does not use parent xml configuration on multi thread deployment - MAGETWO-59310: Static Assets deployment throws errors when redis is used for cache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On this file app/code/Magento/Catalog/view/adminhtml/catalog/product/js.phtml on line 73 I think there is an error when calculating the tax rate, this should read
php spanValue = ' ' + formatCurrency((input.value/100)*rate, priceFormat);instead ofphp spanValue = ' ' + formatCurrency(input.value/(100+rate)*rate, priceFormat);The problem is adding rate to 100(%).
This is present on current Magento EE 1.13 and Magento CE.