Skip to content

Add tests for View\Layout\Reader\Block and slight refactoring #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add tests for View\Layout\Reader\Block and slight refactoring #752

wants to merge 1 commit into from

Conversation

Vinai
Copy link
Contributor

@Vinai Vinai commented Nov 20, 2014

  • Add integration test for View\Layout\Reader\Block
  • Change process() return value to conform with Layout\ReaderInterface
  • Refactor View\Layout\Reader\Block to conform with coding standards

@verklov verklov self-assigned this Dec 9, 2014
@verklov
Copy link
Contributor

verklov commented Dec 9, 2014

Thank you for your contribution, @Vinai!

@maksek
Copy link
Contributor

maksek commented Dec 26, 2014

Hi @Vinai, can you please review you PR, and if it is still actual, review travis and resubmit into develop branch. Thanks

@maksek maksek assigned maksek and unassigned verklov Dec 26, 2014
@Vinai Vinai mentioned this pull request Jan 5, 2015
Merged
@Vinai Vinai closed this Jan 5, 2015
kandy
kandy reviewed Jan 5, 2015
View reviewed changes
...tegration/testsuite/Magento/Framework/View/Layout/Reader/_files/_layout_update_reference.xml
<arguments>
<argument name="test_arg" xsi:type="string">test-argument-value</argument>
</arguments>
<action method="setTestAction">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove action node from layout. It's deprecated. see: Layout Test

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, thats good to know, thanks.
Can you point me to some information or an example what those methods will be replaced with?

@Vinai
Copy link
Contributor Author

Vinai commented Jan 5, 2015

Thanks for the feedback. I updated the PR to the develop branch #906.

mmansoor-magento pushed a commit that referenced this pull request Jan 18, 2017
Merge pull request #752 from magento-troll/MAGETWO-62321
ac07ef1 
MAGETWO-62321: Remove uses of unserialize in Magento_Eav for attribute validate_rules
fe-lix- pushed a commit to fe-lix-/magento2 that referenced this pull request Apr 6, 2018
Merge pull request magento#752 from magento-engcom/737
d5a0c44 
737 Exception in Low stock report for product with another name on additional storeview
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jun 25, 2019
@magento-engcom-team
ENGCOM-5347: magento/graphql-ce:magento#678 Send email to friend mage…
5379d12 
…nto#752

 - Merge Pull Request magento/graphql-ce#752 from rleshchenko/graphql-ce:2.3-develop-678
 - Merged commits:
   1. 63762d6
   2. bbe60dd
   3. 0e59bcf
   4. 2dded7c
   5. a1d87ba
   6. e8c102a
   7. 07e081f
   8. f69dee0
   9. ee8ad58
   10. 193d4d1
taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jun 25, 2019
@naydav
ENGCOM-5347: magento/graphql-ce:magento#678 Send email to friend mage…
dc74c48 
…nto#752
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@maksek maksek

Labels
Progress: needs update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vinai @verklov @maksek @kandy