Fix outlining invoice item price with the header label 'price' #8454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the outlining of the invoice item price with the header label 'price'. In the header the label 'price' has a feed distance of 360: https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php#L99
|
@joost-florijn-kega thank you for your contribution. Unfortunately, we are not accepting PRs to 2.1 branch for now. Delivery procedure to patch releases is more complicated. We are working on establishing this process for 2.1 and 2.0 branches. Looks like this issue exists in develop branch as well. If you would like to fix this issue in develop branch, please, create new pull request to develop. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the outlining of the invoice item price with the header label 'price' by having the same feed distance as used in the header.
In the header the label 'price' has a feed distance of 360:
https://github.com/magento/magento2/blob/develop/app/code/Magento/Sales/Model/Order/Pdf/Invoice.php#L99
This fixes issue #8453