Fixed coding standard violations in the Framework\Controller, Framework\CSS, Framework\Phrase and Framework\Pricing namespace #9334
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk\CSS, Framework\Phrase and Framework\Pricing namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes: - Removed @codingStandardsIgnoreFile at the head of the files - Fixed indentation - Fixed line length - Changed is_null function call to a === null compare
magento-team
pushed a commit
that referenced
this pull request
Apr 21, 2017
…roller, Framework\CSS, Framework\Phrase and Framework\Pricing namespace #9334
|
@dverkade Thank you for the contribution |
dverkade
deleted the
Fix_coding_standard_in_Framework-Controller,_Framework-Css,_Framework-Phrase,_Framework-Pricing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed coding standard violations in the Framework\Controller, Framework\CSS, Framework\Phrase and Framework\Pricing namespace, so that it will be checked bij PHP CS and no longer be ignored while doing CI checks. Made the following changes: