fix: breaking cycle issues and replacing router.push with Links #3330
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| General | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Members | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/members`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Billing and Plans | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/billing`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Integrations | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/integrations`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Import | ||
| </div> | ||
| <Command.Item onSelect={closePalette} className="focus:outline-none"> | ||
| <Link href={`/${workspaceSlug}/settings/imports`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| <div className="flex items-center gap-1.5"> | ||
| <CustomMenu.MenuItem key={moduleDetail.id}> | ||
| <Link | ||
| href={`/${workspaceSlug}/projects/${projectId}/modules/${moduleDetail.id}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| <div className="flex items-center gap-1.5"> | ||
| <CustomMenu.MenuItem key={viewId}> | ||
| <Link | ||
| href={`/${workspaceSlug}/projects/${projectId}/views/${viewId}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| href={`/${workspaceSlug}/projects/${notification.project}/${ | ||
| notification.data.issue_activity.field === "archived_at" ? "archived-issues" : "issues" | ||
| }/${notification.data.issue.id}`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| }} | ||
| href={`/${workspaceSlug}/projects/${project.id}/settings`} |
Check warning
Code scanning / CodeQL
Client-side URL redirect
| Go to issues | ||
| </Button> | ||
| //TODO: Create a new component called Button Link to handle such scenarios | ||
| <Link href={`/${workspaceSlug}/projects/${projectId}/issues`}> |
Check warning
Code scanning / CodeQL
Client-side URL redirect
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>
* fix cycle creation and active cycle map * minor fix in cycle store * create cycle breaking fix * replace last possible bits of router.push with Link --------- Co-authored-by: Rahul R <rahulr@Rahuls-MacBook-Pro.local>
This PR fixes the error in creating a new cycle, restructure the active cycles inside cycles store and review and replace router.pushes