-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support decode the join request by member invite #882
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # mirai-core-api/src/commonMain/kotlin/data/MemberInfo.kt # mirai-core/src/commonMain/kotlin/contact/MemberInfoImpl.kt
e435f27
to
4c757de
Compare
Him188
reviewed
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
请与 dev 合并, 添加了二进制兼容测试, 测试方法: https://github.com/mamoe/mirai/blob/dev/CONTRIBUTING.md#%E6%B3%A8%E6%84%8F%E4%BA%8B%E9%A1%B9
保证二进制兼容性: 在提交前执行 gradlew build, 若有不兼容变更会得到错误. 在提交时将 binary-compatibility-validator.api 一并提交 (如果有修改). (使用 Kotlin/binary-compatibility-validator)
# Conflicts: # buildSrc/src/main/kotlin/Versions.kt
Him188
approved these changes
Jan 21, 2021
Karlatemp
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #458