Plugin: Become more lenient when test tasks are absent #227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new Variant API, introduced in AGP 4+, allows test tasks to be disabled on a per-variant basis with an easier API. The plugin must not expect all test tasks to always be present, since that could result in UnknownTaskExceptions down the line. Now, testTaskOf() uses the less direct "findByName()" API rather than "getByName()" to obtain the AndroidTestTasks, bailing out if a task is absent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible to disable unit tests for any given variant. This has become even more apparent with the introduction of the new
onVariantsAPIs in Android Gradle Plugin 4. The plugin expects all tasks to be present and aggressively obtains the tasks by name (usinggetByName(String). This will throw anUnknownTaskException, which is undesirable.This PR makes the plugin more forgiving when any consumer disables unit test tasks for certain variants. While verifying these cases, the functional tests have been extended to handle foreach loops in the template files as well, which is neat.
Context: #226