-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: allow github OAuth #17
Comments
Is it possible to use an OAuth token instead of returning an error? What's the issue? |
@onovotny, the library PRs are welcome! 🙌 github-tools-vsts/Src/GithubReleasePublish/githubReleasePublish.js Lines 13 to 14 in 24d167e
https://github.com/remixz/publish-release/blob/master/index.js#L76 |
I believe that it's as "easy" as changing line 76 there from Plus whatever overload/config it'd need to support both methods. Like PAT, it's just another type of Authorization header. You don't have to get your own token, you'd use the GitHub endpoint authorization endpoint for that. VSTS would have already taken care of getting the bearer token. There may be a parameter on the endpoint authorization that shows the type, in addition to |
Would like this as well 👍 |
Working on it @tomkerkhove ✋ , meanwhile you can use token authentication! |
<a name="0.5.0"></a> # [0.5.0](v0.4.1...v0.5.0) (2018-07-09) ### Features * allow GitHub OAuth scheme authentication ([893215d](893215d)), closes [#17](#17)
Tested and verified ✔️ Thanks @marceloavf 🎉 |
Allow integration with OAuth authentication, not just Personal Access Token.
Endpoint:
Basic return
Error reference:
Case 1
Case 2
References:
Code 1
Code 2
Code 3
Related to #16
The text was updated successfully, but these errors were encountered: