Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tags API]: Ensure closures called after setup. #2554

Merged
merged 4 commits into from
Mar 8, 2025
Merged

[Tags API]: Ensure closures called after setup. #2554

merged 4 commits into from
Mar 8, 2025

Conversation

DylanPiercey
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Mar 6, 2025

🦋 Changeset detected

Latest commit: 816b92d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/runtime-tags Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 99.45355% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.10%. Comparing base (44fbd20) to head (816b92d).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
packages/runtime-tags/src/dom/template.ts 75.00% 1 Missing ⚠️
...ckages/runtime-tags/src/translator/util/signals.ts 99.35% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2554      +/-   ##
==========================================
+ Coverage   87.06%   87.10%   +0.03%     
==========================================
  Files         352      352              
  Lines       40996    41093      +97     
  Branches     2772     2790      +18     
==========================================
+ Hits        35694    35794     +100     
+ Misses       5277     5274       -3     
  Partials       25       25              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DylanPiercey DylanPiercey merged commit f5b8548 into main Mar 8, 2025
10 checks passed
@DylanPiercey DylanPiercey deleted the wip branch March 8, 2025 01:47
@github-actions github-actions bot mentioned this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant