infoWorldTimeFormatted showing incorrect day #9
Comments
|
Yes, I guess it's debatable whether or not the first day in a world should be day 1 or day 0. Might depend on whether or not the player is a programmer... :p Currently the mod specifically adds 1 to the value: https://github.com/maruohon/minihud/blob/master/src/main/java/fi/dy/masa/minihud/event/RenderEventHandler.java#L323 Should I add a config option just for this (whether or not to add that one)? |
|
Yeah, I think giving an option to the player would be best, especially since it's debatable. Nice mod by the way |
maruohon
pushed a commit
that referenced
this issue
Aug 20, 2024
* initial BlockEntityData data storage interface built * Block / Entity Data classes start * successful comms online for entity_data channel * Entity syncer (#4) * feat: handle response * feat: handle response * fix * fix * fix * fix * style: reformat * feat: add getTargetEntity() and request entity data * fix: do not refresh position when loading nbt * fix: vanilla query * fix: loadNbtIntoEntity * fix: vanilla query * feat: limit request rate at 50ms, 1 server tick * Update packet splitter response code for Entity Data * fix: Added rate limiter for querying server nbt data, fix injecting points for `handleVanllaQueryNbt` (#6) * fix: injecting point, you are invoking EntitiesDataStorage.handleVanillaQueryNbt on network thread, not client thread! * fix: deleted these code mistakenly * feat: add a queue to limit request rate TODO: configurable * feat: option SERVER_NBT_REQUEST_RATE * chore * fix: leash disappears when loading nbt (#7) * fix: leash disappears when loading nbt to client * fix: leash disappears when loading nbt to client * Add handling for when "looking At" a Horse/Mount for their Run Speed and Jump Strength, and with a setting called "LOOKING_AT_HORSE" * Fixed "Looking At Horse" to not be a Config. Added "time remaining" for Passive Entities for growing up. * feat: Villager trade display (#5) * feat: show villager offers overlay for enchanted books This is a survival QoL feature * style * style * style * fix: sync server data * feat: display the offer overlay at the villager's job site * fix * Added indicator colors for the Trade price * Added indicator colors for the Trade price * chore * fix: NPE * feat: villagerOfferLowestPriceNearby * fix * feat: villagerConversionTicks renderer * fix --------- Co-authored-by: Sakura Ryoko <sakura@ryoko.soy> Co-authored-by: Sakura Ryoko <116967773+sakura-ryoko@users.noreply.github.com> * Some code cleanups / packet Splitter for SENDING bulk data to server (To be cloned for Litematica) * feat: Inventory preview (#8) * feat: copy inventory preview stuff from tweakeroo * fix * feat: inventory preview for players; inventoryPreviewToggleScreen to toggle screen mode; screen mode, to make the player able to move cursor to see tooltips * fix * fix * fix * fix * feat: piglin * fix * chore * fix * fix malilib version * fix default keybind of inventory_preview_toggle * fix: dont break vanilla pick block * Verify fix of BUTTON_3 for the default --------- Co-authored-by: Sakura Ryoko <sakura@ryoko.soy> * Add Entity Data Sync configs, malilib sakura 6 * Code CLean up * Code CLean up --------- Co-authored-by: Liyan Zhao <return65535@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Formatted world time option displays a day over what is displayed on the F3 screen
The text was updated successfully, but these errors were encountered: