Fix streaming server not filtering unknown-language posts from public timelines #33774
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ic timelines Fixes #33742
ThisIsMissEm
reviewed
Feb 8, 2025
ClearlyClaire
changed the title
mjankowski
added
javascript
vmstan
approved these changes
Feb 15, 2025
|
Been running on vmst.io for a few days and haven't seen any issues. |
oneiros
approved these changes
Feb 17, 2025
ClearlyClaire
added a commit
that referenced
this pull request
Mar 7, 2025
ClearlyClaire
added a commit
that referenced
this pull request
Mar 7, 2025
ClearlyClaire
added a commit
that referenced
this pull request
Mar 10, 2025
ClearlyClaire
added a commit
that referenced
this pull request
Mar 10, 2025
kmycode
pushed a commit
to kmycode/mastodon
that referenced
this pull request
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33742
I am not 100% sure whether we want the streaming server to adopt the REST API behavior (this PR), or the REST API behavior to change to adopt the streaming server's behavior, but I have a preference for the former, hence the PR.