chore(infrastructure): Fix all type errors except for ripple imports #951
Conversation
This was disabled before due to existing failures. Let's clean them up :-) #936
Codecov Report
@@ Coverage Diff @@
## rc0.14.0 #951 +/- ##
=========================================
Coverage 94.12% 94.12%
=========================================
Files 86 86
Lines 3644 3644
Branches 576 576
=========================================
Hits 3430 3430
Misses 90 90
Partials 124 124Continue to review full report at Codecov.
|
| @@ -23,7 +23,7 @@ | |||
| "@material/drawer": "^2.3.0", | |||
| "@material/list": "^2.3.0", | |||
| "classnames": "^2.2.6", | |||
| "focus-trap": "^4.0.2" | |||
| "focus-trap": "^5.0.0" | |||
There was a problem hiding this comment.
@moog16 see note on main package.json
| @@ -22,7 +22,7 @@ | |||
| "@material/dom": "^1.0.0", | |||
| "@material/react-button": "^0.13.0", | |||
| "classnames": "^2.2.6", | |||
| "focus-trap": "^4.0.2" | |||
| "focus-trap": "^5.0.0" | |||
There was a problem hiding this comment.
@moog16 see note on main package.json
| @@ -135,6 +135,7 @@ | |||
| "eslint-plugin-prettier": "^3.1.0", | |||
| "eslint-plugin-react": "^7.7.0", | |||
| "eslint-plugin-typescript": "^0.14.0", | |||
| "focus-trap": "^5.0.0", | |||
There was a problem hiding this comment.
@moog16 I'm requiring this here to prevent sub-packages from installing it twice. I'm updating the version to the 5.x branch because dependencies have updated to use it and conflicts result if not.
There was a problem hiding this comment.
Let's remove this. The repository does not depend on focus-trap.
There was a problem hiding this comment.
There was a problem hiding this comment.
ah you're right - in the tests. Thanks!
| @@ -102,7 +102,7 @@ | |||
| "@types/puppeteer": "^1.11.1", | |||
| "@types/react": "~16.7.22", | |||
| "@types/react-dom": "~16.0.11", | |||
| "@types/react-is": "^16.7.1", | |||
| "@types/react-is": "~16.5.0", | |||
There was a problem hiding this comment.
@moog16 I'm rolling this back to one released at the same time as @types/react ~16.7.22 due to conflicts.
| @@ -93,7 +93,7 @@ | |||
| "@material/typography": "^1.0.0", | |||
| "@types/chai": "^4.1.7", | |||
| "@types/classnames": "^2.2.6", | |||
| "@types/enzyme": "^3.1.15", | |||
| "@types/enzyme": "3.1.15", | |||
There was a problem hiding this comment.
@moog16 it turns out that this is the last type compatible version for @types/react ~16.7.22
arichiv
changed the title
Type Check on all buildsType Check on all builds
|
Important note: this does not modernize all type dependencies within the repo, but does reduce existing errors to 0 and automatically checks to ensure future changes do not break anything :-) |
|
That's not good. I'll play around with it locally then :-( |
arichiv
changed the title
Type Check on all builds
|
@moog16 https://travis-ci.com/material-components/material-components-web-react/jobs/210813262 shows a build that works, except for the (now detected) ripple errors. |
|
#952 is a better fix. Will wait for commit. |
arichiv
changed the title
arichiv
changed the title
arichiv
changed the title
|
@moog16 this is ready for merge then. The next PR will uncomment the travis-ci test and fix ripple imports. This fixes all other package version errors :-) |
|
Manually tested...everything looks good :) |
This fixes packages at the version needed to successfully import them into a local project. Does not fix the issue with relative ripple imports.
#936