Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

fix(ripple) broken relative imports #953

Merged
merged 39 commits into from
Jul 2, 2019
Merged

fix(ripple) broken relative imports #953

merged 39 commits into from
Jul 2, 2019

Conversation

arichiv
Copy link
Contributor

@arichiv arichiv commented Jun 25, 2019

The issue seems to be at the webpack stage; we need to prevent it looking across packages.
This should be the final fix for #936

The issue seems to be at the webpack stage; we need to prevent it looking across packages.
This should be the final fix for #936
@arichiv arichiv changed the title [WIP] Fix ripple imports [WIP] fix(ripple) broken relative imports Jun 25, 2019
@codecov-io
Copy link

codecov-io commented Jun 25, 2019

Codecov Report

Merging #953 into rc0.15.0 will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           rc0.15.0     #953   +/-   ##
=========================================
  Coverage     94.12%   94.12%           
=========================================
  Files            86       86           
  Lines          3645     3645           
  Branches        576      576           
=========================================
  Hits           3431     3431           
  Misses           90       90           
  Partials        124      124
Impacted Files Coverage Δ
packages/tab/TabRipple.tsx 100% <ø> (ø) ⬆️
packages/fab/index.tsx 92.59% <100%> (ø) ⬆️
packages/button/index.tsx 96.77% <100%> (ø) ⬆️
packages/material-icon/index.tsx 100% <100%> (ø) ⬆️
packages/checkbox/index.tsx 88.6% <100%> (ø) ⬆️
packages/list/ListItem.tsx 99.01% <100%> (ø) ⬆️
packages/radio/index.tsx 93.84% <100%> (ø) ⬆️
packages/chips/Chip.tsx 88.28% <100%> (ø) ⬆️
packages/icon-button/index.tsx 97.91% <100%> (ø) ⬆️
packages/card/PrimaryContent.tsx 92.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00f2ef1...42c9489. Read the comment docs.

@moog16
Copy link

moog16 commented Jun 25, 2019

@arichiv great! Thanks for driving this home. I was going to do a release today. I think I'm going to go ahead with it. This can be a patch release.

@dorivaught dorivaught added this to the Sprint 6: June 25-July 8 milestone Jun 25, 2019
@arichiv
Copy link
Contributor Author

arichiv commented Jun 25, 2019

For sure! I can rebase on whatever, and the changes from this could use longer to bake IMO

@moog16
Copy link

moog16 commented Jun 25, 2019

agreed! sounds good

@arichiv arichiv changed the base branch from rc0.14.0 to rc0.15.0 June 26, 2019 16:09
@arichiv arichiv changed the base branch from rc0.15.0 to rc0.14.0 June 26, 2019 16:10
@arichiv
Copy link
Contributor Author

arichiv commented Jun 26, 2019

Looks like it's not webpack, it's in the typescript build itself

@arichiv arichiv changed the title [WIP] fix(ripple) broken relative imports fix(ripple) broken relative imports Jun 28, 2019
@arichiv
Copy link
Contributor Author

arichiv commented Jun 28, 2019

@moog16 ready!

@arichiv arichiv changed the base branch from rc0.14.0 to rc0.15.0 June 30, 2019 01:56
@moog16
Copy link

moog16 commented Jul 2, 2019

When I run the tests it creates some files. Please add ./test/types/index.ts and ./test/types/tsconfig.json to the .gitignore. Looks good though :)

@arichiv
Copy link
Contributor Author

arichiv commented Jul 2, 2019

When I run the tests it creates some files. Please add ./test/types/index.ts and ./test/types/tsconfig.json to the .gitignore. Looks good though :)

Done!

@moog16 moog16 merged commit aabe0c1 into material-components:rc0.15.0 Jul 2, 2019
@arichiv arichiv deleted the patch-1 branch July 2, 2019 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants