Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix miscellaneous issues with components #1227

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

dpvc
Copy link
Member

@dpvc dpvc commented Mar 4, 2025

This PR makes miscellaneous updates to various component configurations and related changes.

  • A ui/menu dependency on a11y/sre is added (since SpeechMenu.ts uses it).
  • The output/chtml and output/svg config files now target common.ts, so that that will be included in the MathJax._ tree, and the components/src/startup/lib is added so that ts/components/package.ts will be shared properly. (Otherwise this leads to two separate copies of the Package class that don't know about what the other one has loaded.)
  • The webpack.common.js and package.json are modified to allow compoments/js to obtain compoments/mjs or components/cjs depending on whether it is used in an import or a require(). (The older components/src is still there for backward compatibility with v3, before we had the mjs/cjs split).
  • The global.ts file is modified to check that the MathJax variable is actually an object literal, rather than a string or array or some other thing.
  • The all-packages component is remove from the \require list, since that component was removed in a previous PR.

@dpvc dpvc requested a review from zorkow March 4, 2025 18:03
@dpvc dpvc added this to the v4.0 milestone Mar 4, 2025
Copy link
Member

@zorkow zorkow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants