-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VisitFrequency plugin language reworked #19467
base: 4.x-dev
Are you sure you want to change the base?
Conversation
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
I'm in general not sure if changing |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
"ColumnAverageVisitDurationForNewVisitors": "Avg. amount of seconds spent by new visitors", | ||
"ColumnAverageVisitDurationForReturningVisitors": "Avg. amount of seconds spent by returning visitors", | ||
"ColumnAvgActionsPerNewVisit": "Avg. actions per new visitor", | ||
"ColumnAvgActionsPerReturningVisit": "Avg. actions per returning visitor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Potentially misleading
"ColumnBounceRateForNewVisits": "Bounce rate for new visitors", | ||
"ColumnBounceRateForReturningVisits": "Bounce rate for returning visitors", | ||
"ColumnMaxActionsInReturningVisit": "Max actions in one returning visit", | ||
"ColumnNbReturningVisitsConverted": "Number of converted returning visitors", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ColumnNbReturningVisitsConverted": "Number of converted returning visitors", | |
"ColumnNbReturningVisitsConverted": "Number of converted visits made by returning visitors", |
"PluginDescription": "Reports metrics about your returning and (first time) new visitors.", | ||
"ReturnActions": "actions by the returning visitors", | ||
"ReturnAverageVisitDuration": "avg. time spent by returning visitors calculated from each of their visists", | ||
"ReturnAvgActions": "actions per returning visitor", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ReturnAvgActions": "actions per returning visitor", | |
"ReturnAvgActions": "actions per visit for returning visitors", |
This PR was last updated more than one month ago, maybe it's time to close it. Please check if there is anything we still can do or close this PR. ping @matomo-org/core-reviewers |
If you don't want this PR to be closed automatically in 28 days then you need to assign the label 'Do not close'. |
Description:
Generally shorter and to the point.
In line with other edits.
Can't get to what I think is the relevant UI parts without an account, but alas.
Visits aren't the thing that returns, as they have to be separate events to be returning.
Similarly, visitors (as opposed to visits) carry out actions.
Review