Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Manual Control to support 6dof #2005

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

InvincibleRMC
Copy link
Contributor

@InvincibleRMC InvincibleRMC commented Oct 20, 2024

Updated message definition found here.

Tested on my pixhawk running ArduSub by reading /mavros/rc/out.

Copy link
Member

@vooon vooon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Except I'm not sure about aux, maybe better aux[6]. But at the same time command params are after mavlink...

@InvincibleRMC
Copy link
Contributor Author

Overall looks good. Except I'm not sure about aux, maybe better aux[6]. But at the same time command params are after mavlink...

Let me know if you for certain want me to make it aux[6] or if it is fine the way it is. I do not have a strong preference.

@vooon
Copy link
Member

vooon commented Oct 23, 2024

I don't have strong preference on array, so it's okay to stick to mavlink definition.

@vooon vooon merged commit b490957 into mavlink:ros2 Oct 23, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants