Skip to content

Added for await... of example #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Added for await... of example #1298

wants to merge 8 commits into from

Conversation

jahzielv
Copy link
Contributor

Contributing this example as part of a documentation effort for async iteration, which can be seen here: tc39/proposal-async-iteration#132.

@welcome
Copy link

welcome bot commented Jan 22, 2019

💖 Thanks for opening this pull request! 💖
Here is a list of things that will help get it across the finish line:

  • If this is a new or updated CSS interactive example, please ensure that you followed the CSS styleguide - If this is a new or updated JavaScript interactive example, please ensure that you followed the JavaScript styleguide - If your changes affects any of the steps in our contribution docs, please also make the relevant changes there.

@jahzielv
Copy link
Contributor Author

Realized that I added my code to the wrong folder; moving it to the /statement directory.

@jahzielv
Copy link
Contributor Author

Is there anything I can do to move this PR forward?

@wbamberg wbamberg requested a review from Elchi3 January 28, 2019 15:38
@wbamberg
Copy link
Contributor

Thanks for your contribution @jahzielv !

I'm going to ask Florian to take a look at when he digs into the async interation doc updates. My initial reaction though is that it is too complex for an interactive example, although I don't know this stuff well enough to know whether it's possible to simplify it.

Do you have to write your own async generator, or is it possible to use one that's already implemented in an API?

I'd also prefer to have examples that are self-contained and don't depend on any other sites, although I could see that this might conflict with making the example simpler.

@jahzielv
Copy link
Contributor Author

Hi @wbamberg ! Thanks for welcoming me and for your feedback; I'm excited to be contributing to this project!

I definitely agree that it's a little longer than most interactive examples, and I looked for a way to make it it more concise, but couldn't find any - all examples I can find online use custom generators. I'm not sure that there's any web APIs that currently implement async iterables, but I could be totally wrong about that.

I also see your point about depending on external sites; it's not great from a maintainability POV since you don't control what's going on elsewhere. I can't think of a way to avoid it though, since async iteration seems to be aimed mostly at streaming data, and like you said, avoiding it would add more code. I'm down to make any changes you and @Elchi3 suggest to improve the example!

@jahzielv jahzielv closed this Aug 5, 2019
@Elchi3 Elchi3 removed their request for review August 6, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants