Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to add new admin route under existing route #10652

Merged
merged 4 commits into from
Jan 20, 2025

Conversation

eugenepro2
Copy link
Contributor

This PR updated docs and describe how to add new admin route under existing route.
Ref: #10587 (comment)

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: aafda70

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Dec 18, 2024

@eugenepro2 is attempting to deploy a commit to the medusajs Team on Vercel.

A member of the Team first needs to authorize it.

@eugenepro2 eugenepro2 marked this pull request as ready for review December 18, 2024 08:52
@eugenepro2 eugenepro2 requested a review from a team as a code owner December 18, 2024 08:52
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this PR! Just need a few changes

@@ -145,6 +145,32 @@ Some caveats for nested UI routes in the sidebar:
- Nested routes in setting pages aren't shown in the sidebar to follow the admin's design conventions.
- The `icon` configuration is ignored for the sidebar item of nested UI route to follow the admin's design conventions.


### Route Under Existing Admin Route
You can locate a route under an existing route. For example, you can locate a route under the orders route in the sidebar.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can locate a route under an existing route. For example, you can locate a route under the orders route in the sidebar.
You can add a custom UI route under an existing route. For example, you can add a route under the orders route:

@eugenepro2
Copy link
Contributor Author

@shahednasser Thanks for your suggestions. I've committed this changes. Please have a look.

eugenepro2 and others added 2 commits December 19, 2024 09:56
Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
Copy link
Member

@shahednasser shahednasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks! Will merge this once the next release is out.

@eugenepro2
Copy link
Contributor Author

@shahednasser can you merge it?

@shahednasser shahednasser merged commit b278ee5 into medusajs:develop Jan 20, 2025
22 of 30 checks passed
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
* docs: how to add new admin route under existing route

* docs: update about defineRouteConfig

* docs: add new line

Co-authored-by: Shahed Nasser <shahednasser@gmail.com>

* docs: add new line

---------

Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
* docs: how to add new admin route under existing route

* docs: update about defineRouteConfig

* docs: add new line

Co-authored-by: Shahed Nasser <shahednasser@gmail.com>

* docs: add new line

---------

Co-authored-by: Shahed Nasser <shahednasser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants