Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows): data passed to to fulfillment provider context #10660

Merged
merged 2 commits into from
Dec 18, 2024
Merged

fix(core-flows): data passed to to fulfillment provider context #10660

merged 2 commits into from
Dec 18, 2024

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Dec 18, 2024 •
edited
Loading

What

  • consolidate data sent to calculate SO price context
  • pass from_location to validateFulfillmentData
    • don't set stock location on a SO in listShippingOptionsForCartWorkflow and set it in listShippingOptionsForCartWithPricingWorkflow

@fPolic fPolic requested a review from a team as a code owner December 18, 2024 15:03
@vercel Vercel
Copy link

vercel bot commented Dec 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 18, 2024 6:35pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Dec 18, 2024 6:35pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:35pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:35pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:35pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:35pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Dec 18, 2024 6:35pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5f2e39b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl olivermrbl merged commit 3dba551 into develop Dec 18, 2024
23 checks passed
@olivermrbl olivermrbl deleted the fix/calculate-so-context-fields branch December 18, 2024 20:23
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
@fPolic @noubase
fix(core-flows): data passed to to fulfillment provider context (medu…
b854883 
…sajs#10660)

* fix: cart data passed to context, from location in validation

* refactor: extract common fields to a const
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@fPolic @jimrarras
fix(core-flows): data passed to to fulfillment provider context (medu…
91d079a 
…sajs#10660)

* fix: cart data passed to context, from location in validation

* refactor: extract common fields to a const
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@adrien2p adrien2p Awaiting requested review from adrien2p adrien2p is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl