Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add translations for Macedonian #11039

Merged
merged 1 commit into from
Jan 20, 2025
Merged

feat: Add translations for Macedonian #11039

merged 1 commit into from
Jan 20, 2025

Conversation

sradevski
Copy link
Member

I figured I should at least translate Medusa in my own language 😄

I did some AI translation first, and did a quick round of obvious improvements. Can be made better but it's pretty good as-is.

@sradevski sradevski requested a review from a team as a code owner January 18, 2025 14:47
Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:22pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 20, 2025 4:22pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:22pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:22pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:22pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 20, 2025 4:22pm
resources-docs ⬜️ Ignored (Inspect) Jan 20, 2025 4:22pm

@sradevski
Copy link
Member Author

@kasperkristensen I noticed something weird, there are these 2 fields that are missing, but when I added them it says "unknown key", what am I missing here? They are also missing in eg. en.json

Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haha, I like it 😄

@kasperkristensen
Copy link
Contributor

@kasperkristensen I noticed something weird, there are these 2 fields that are missing, but when I added them it says "unknown key", what am I missing here? They are also missing in eg. en.json

Seems like the keys were deleted from the en.json file, but the schema command wasn't ran.

You can just run yarn i18n:schema to fix the schema and then the test will go through 👍

Copy link

changeset-bot bot commented Jan 20, 2025

⚠️ No Changeset found

Latest commit: e8979fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kodiakhq kodiakhq bot merged commit a0fc612 into develop Jan 20, 2025
24 checks passed
@kodiakhq kodiakhq bot deleted the feat/translate-mk branch January 20, 2025 16:37
noubase pushed a commit to noubase/medusa that referenced this pull request Jan 22, 2025
I figured I should at least translate Medusa in my own language 😄 

I did some AI translation first, and did a quick round of obvious improvements. Can be made better but it's pretty good as-is.
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
I figured I should at least translate Medusa in my own language 😄

I did some AI translation first, and did a quick round of obvious improvements. Can be made better but it's pretty good as-is.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants