Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core-flows, dashboard): handling fulfillment rules #11111

Merged
merged 4 commits into from
Jan 23, 2025
Merged

fix(core-flows, dashboard): handling fulfillment rules #11111

merged 4 commits into from
Jan 23, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Jan 23, 2025

What

  • fix storing "true" | "false" strings from admin
  • use strings instead of booleans for context filtering

@fPolic fPolic requested a review from a team as a code owner January 23, 2025 11:42
@vercel Vercel
Copy link

vercel bot commented Jan 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2025 1:07pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 23, 2025 1:07pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:07pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:07pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:07pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:07pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 1:07pm

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.4.0-snapshot-20250123120346
yarn add @medusajs/admin-sdk@2.4.0-snapshot-20250123120346
yarn add @medusajs/admin-shared@2.4.0-snapshot-20250123120346
yarn add @medusajs/admin-vite-plugin@2.4.0-snapshot-20250123120346
yarn add @medusajs/dashboard@2.4.0-snapshot-20250123120346
yarn add create-medusa-app@2.4.0-snapshot-20250123120346
yarn add @medusajs/cli@2.4.0-snapshot-20250123120346
yarn add medusa-dev-cli@2.4.0-snapshot-20250123120346
yarn add @medusajs/medusa-oas-cli@2.4.0-snapshot-20250123120346
yarn add @medusajs/core-flows@2.4.0-snapshot-20250123120346
yarn add @medusajs/framework@2.4.0-snapshot-20250123120346
yarn add @medusajs/js-sdk@2.4.0-snapshot-20250123120346
yarn add @medusajs/modules-sdk@2.4.0-snapshot-20250123120346
yarn add @medusajs/orchestration@2.4.0-snapshot-20250123120346
yarn add @medusajs/types@2.4.0-snapshot-20250123120346
yarn add @medusajs/utils@2.4.0-snapshot-20250123120346
yarn add @medusajs/workflows-sdk@2.4.0-snapshot-20250123120346
yarn add @medusajs/icons@2.4.0-snapshot-20250123120346
yarn add @medusajs/ui@4.0.4-snapshot-20250123120346
yarn add @medusajs/ui-preset@2.4.0-snapshot-20250123120346
yarn add @medusajs/medusa@2.4.0-snapshot-20250123120346
yarn add @medusajs/telemetry@2.4.0-snapshot-20250123120346
yarn add @medusajs/test-utils@2.4.0-snapshot-20250123120346
yarn add @medusajs/api-key@2.4.0-snapshot-20250123120346
yarn add @medusajs/auth@2.4.0-snapshot-20250123120346
yarn add @medusajs/cache-inmemory@2.4.0-snapshot-20250123120346
yarn add @medusajs/cache-redis@2.4.0-snapshot-20250123120346
yarn add @medusajs/cart@2.4.0-snapshot-20250123120346
yarn add @medusajs/currency@2.4.0-snapshot-20250123120346
yarn add @medusajs/customer@2.4.0-snapshot-20250123120346
yarn add @medusajs/event-bus-local@2.4.0-snapshot-20250123120346
yarn add @medusajs/event-bus-redis@2.4.0-snapshot-20250123120346
yarn add @medusajs/file@2.4.0-snapshot-20250123120346
yarn add @medusajs/fulfillment@2.4.0-snapshot-20250123120346
yarn add @medusajs/index@2.4.0-snapshot-20250123120346
yarn add @medusajs/inventory@2.4.0-snapshot-20250123120346
yarn add @medusajs/link-modules@2.4.0-snapshot-20250123120346
yarn add @medusajs/locking@2.4.0-snapshot-20250123120346
yarn add @medusajs/notification@2.4.0-snapshot-20250123120346
yarn add @medusajs/order@2.4.0-snapshot-20250123120346
yarn add @medusajs/payment@2.4.0-snapshot-20250123120346
yarn add @medusajs/pricing@2.4.0-snapshot-20250123120346
yarn add @medusajs/product@2.4.0-snapshot-20250123120346
yarn add @medusajs/promotion@2.4.0-snapshot-20250123120346
yarn add @medusajs/auth-emailpass@2.4.0-snapshot-20250123120346
yarn add @medusajs/auth-github@2.4.0-snapshot-20250123120346
yarn add @medusajs/auth-google@2.4.0-snapshot-20250123120346
yarn add @medusajs/file-local@2.4.0-snapshot-20250123120346
yarn add @medusajs/file-s3@2.4.0-snapshot-20250123120346
yarn add @medusajs/fulfillment-manual@2.4.0-snapshot-20250123120346
yarn add @medusajs/locking-postgres@2.4.0-snapshot-20250123120346
yarn add @medusajs/locking-redis@2.4.0-snapshot-20250123120346
yarn add @medusajs/notification-local@2.4.0-snapshot-20250123120346
yarn add @medusajs/notification-sendgrid@2.4.0-snapshot-20250123120346
yarn add @medusajs/payment-stripe@2.4.0-snapshot-20250123120346
yarn add @medusajs/region@2.4.0-snapshot-20250123120346
yarn add @medusajs/sales-channel@2.4.0-snapshot-20250123120346
yarn add @medusajs/stock-location@2.4.0-snapshot-20250123120346
yarn add @medusajs/store@2.4.0-snapshot-20250123120346
yarn add @medusajs/tax@2.4.0-snapshot-20250123120346
yarn add @medusajs/user@2.4.0-snapshot-20250123120346
yarn add @medusajs/workflow-engine-inmemory@2.4.0-snapshot-20250123120346
yarn add @medusajs/workflow-engine-redis@2.4.0-snapshot-20250123120346

Latest commit: 5aa4797

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9e685d5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@olivermrbl
Copy link
Contributor

/snapshot-this

@github-actions GitHub Actions
Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.4.0-snapshot-20250123131135
yarn add @medusajs/admin-sdk@2.4.0-snapshot-20250123131135
yarn add @medusajs/admin-shared@2.4.0-snapshot-20250123131135
yarn add @medusajs/admin-vite-plugin@2.4.0-snapshot-20250123131135
yarn add @medusajs/dashboard@2.4.0-snapshot-20250123131135
yarn add create-medusa-app@2.4.0-snapshot-20250123131135
yarn add @medusajs/cli@2.4.0-snapshot-20250123131135
yarn add medusa-dev-cli@2.4.0-snapshot-20250123131135
yarn add @medusajs/medusa-oas-cli@2.4.0-snapshot-20250123131135
yarn add @medusajs/core-flows@2.4.0-snapshot-20250123131135
yarn add @medusajs/framework@2.4.0-snapshot-20250123131135
yarn add @medusajs/js-sdk@2.4.0-snapshot-20250123131135
yarn add @medusajs/modules-sdk@2.4.0-snapshot-20250123131135
yarn add @medusajs/orchestration@2.4.0-snapshot-20250123131135
yarn add @medusajs/types@2.4.0-snapshot-20250123131135
yarn add @medusajs/utils@2.4.0-snapshot-20250123131135
yarn add @medusajs/workflows-sdk@2.4.0-snapshot-20250123131135
yarn add @medusajs/icons@2.4.0-snapshot-20250123131135
yarn add @medusajs/ui@4.0.4-snapshot-20250123131135
yarn add @medusajs/ui-preset@2.4.0-snapshot-20250123131135
yarn add @medusajs/medusa@2.4.0-snapshot-20250123131135
yarn add @medusajs/telemetry@2.4.0-snapshot-20250123131135
yarn add @medusajs/test-utils@2.4.0-snapshot-20250123131135
yarn add @medusajs/api-key@2.4.0-snapshot-20250123131135
yarn add @medusajs/auth@2.4.0-snapshot-20250123131135
yarn add @medusajs/cache-inmemory@2.4.0-snapshot-20250123131135
yarn add @medusajs/cache-redis@2.4.0-snapshot-20250123131135
yarn add @medusajs/cart@2.4.0-snapshot-20250123131135
yarn add @medusajs/currency@2.4.0-snapshot-20250123131135
yarn add @medusajs/customer@2.4.0-snapshot-20250123131135
yarn add @medusajs/event-bus-local@2.4.0-snapshot-20250123131135
yarn add @medusajs/event-bus-redis@2.4.0-snapshot-20250123131135
yarn add @medusajs/file@2.4.0-snapshot-20250123131135
yarn add @medusajs/fulfillment@2.4.0-snapshot-20250123131135
yarn add @medusajs/index@2.4.0-snapshot-20250123131135
yarn add @medusajs/inventory@2.4.0-snapshot-20250123131135
yarn add @medusajs/link-modules@2.4.0-snapshot-20250123131135
yarn add @medusajs/locking@2.4.0-snapshot-20250123131135
yarn add @medusajs/notification@2.4.0-snapshot-20250123131135
yarn add @medusajs/order@2.4.0-snapshot-20250123131135
yarn add @medusajs/payment@2.4.0-snapshot-20250123131135
yarn add @medusajs/pricing@2.4.0-snapshot-20250123131135
yarn add @medusajs/product@2.4.0-snapshot-20250123131135
yarn add @medusajs/promotion@2.4.0-snapshot-20250123131135
yarn add @medusajs/auth-emailpass@2.4.0-snapshot-20250123131135
yarn add @medusajs/auth-github@2.4.0-snapshot-20250123131135
yarn add @medusajs/auth-google@2.4.0-snapshot-20250123131135
yarn add @medusajs/file-local@2.4.0-snapshot-20250123131135
yarn add @medusajs/file-s3@2.4.0-snapshot-20250123131135
yarn add @medusajs/fulfillment-manual@2.4.0-snapshot-20250123131135
yarn add @medusajs/locking-postgres@2.4.0-snapshot-20250123131135
yarn add @medusajs/locking-redis@2.4.0-snapshot-20250123131135
yarn add @medusajs/notification-local@2.4.0-snapshot-20250123131135
yarn add @medusajs/notification-sendgrid@2.4.0-snapshot-20250123131135
yarn add @medusajs/payment-stripe@2.4.0-snapshot-20250123131135
yarn add @medusajs/region@2.4.0-snapshot-20250123131135
yarn add @medusajs/sales-channel@2.4.0-snapshot-20250123131135
yarn add @medusajs/stock-location@2.4.0-snapshot-20250123131135
yarn add @medusajs/store@2.4.0-snapshot-20250123131135
yarn add @medusajs/tax@2.4.0-snapshot-20250123131135
yarn add @medusajs/user@2.4.0-snapshot-20250123131135
yarn add @medusajs/workflow-engine-inmemory@2.4.0-snapshot-20250123131135
yarn add @medusajs/workflow-engine-redis@2.4.0-snapshot-20250123131135

Latest commit: 3138485

@kodiakhq kodiakhq bot merged commit 6e59126 into develop Jan 23, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/so-rules-type branch January 23, 2025 16:32
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
@fPolic @jimrarras
fix(core-flows, dashboard): handling fulfillment rules (medusajs#11111)
217b445 
**What**
- fix storing "true" | "false" strings from admin
- use strings instead of booleans for context filtering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-r-l-rodrigues carlos-r-l-rodrigues carlos-r-l-rodrigues approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@sradevski sradevski Awaiting requested review from sradevski sradevski is a code owner automatically assigned from medusajs/engineering

@riqwan riqwan Awaiting requested review from riqwan riqwan is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fPolic @olivermrbl @carlos-r-l-rodrigues