Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(medusa): add sku to variant query params #11151

Merged
merged 4 commits into from
Jan 28, 2025
Merged

Conversation

riqwan
Copy link
Contributor

@riqwan riqwan commented Jan 25, 2025

what:

  • adds sku to variant query params

Copy link

vercel bot commented Jan 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 10:10am
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 28, 2025 10:10am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:10am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:10am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:10am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:10am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 10:10am

Copy link

changeset-bot bot commented Jan 25, 2025

⚠️ No Changeset found

Latest commit: 5e5947e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@riqwan
Copy link
Contributor Author

riqwan commented Jan 25, 2025

/snapshot-this

Copy link
Contributor

🚀 A snapshot release has been made for this PR

Test the snapshots by updating your package.json with the newly published versions:

yarn add @medusajs/admin-bundler@2.4.0-snapshot-20250125144527
yarn add @medusajs/admin-sdk@2.4.0-snapshot-20250125144527
yarn add @medusajs/admin-shared@2.4.0-snapshot-20250125144527
yarn add @medusajs/admin-vite-plugin@2.4.0-snapshot-20250125144527
yarn add @medusajs/dashboard@2.4.0-snapshot-20250125144527
yarn add create-medusa-app@2.4.0-snapshot-20250125144527
yarn add @medusajs/cli@2.4.0-snapshot-20250125144527
yarn add medusa-dev-cli@2.4.0-snapshot-20250125144527
yarn add @medusajs/medusa-oas-cli@2.4.0-snapshot-20250125144527
yarn add @medusajs/core-flows@2.4.0-snapshot-20250125144527
yarn add @medusajs/framework@2.4.0-snapshot-20250125144527
yarn add @medusajs/js-sdk@2.4.0-snapshot-20250125144527
yarn add @medusajs/modules-sdk@2.4.0-snapshot-20250125144527
yarn add @medusajs/orchestration@2.4.0-snapshot-20250125144527
yarn add @medusajs/types@2.4.0-snapshot-20250125144527
yarn add @medusajs/utils@2.4.0-snapshot-20250125144527
yarn add @medusajs/workflows-sdk@2.4.0-snapshot-20250125144527
yarn add @medusajs/icons@2.4.0-snapshot-20250125144527
yarn add @medusajs/ui@4.0.4-snapshot-20250125144527
yarn add @medusajs/ui-preset@2.4.0-snapshot-20250125144527
yarn add @medusajs/medusa@2.4.0-snapshot-20250125144527
yarn add @medusajs/telemetry@2.4.0-snapshot-20250125144527
yarn add @medusajs/test-utils@2.4.0-snapshot-20250125144527
yarn add @medusajs/api-key@2.4.0-snapshot-20250125144527
yarn add @medusajs/auth@2.4.0-snapshot-20250125144527
yarn add @medusajs/cache-inmemory@2.4.0-snapshot-20250125144527
yarn add @medusajs/cache-redis@2.4.0-snapshot-20250125144527
yarn add @medusajs/cart@2.4.0-snapshot-20250125144527
yarn add @medusajs/currency@2.4.0-snapshot-20250125144527
yarn add @medusajs/customer@2.4.0-snapshot-20250125144527
yarn add @medusajs/event-bus-local@2.4.0-snapshot-20250125144527
yarn add @medusajs/event-bus-redis@2.4.0-snapshot-20250125144527
yarn add @medusajs/file@2.4.0-snapshot-20250125144527
yarn add @medusajs/fulfillment@2.4.0-snapshot-20250125144527
yarn add @medusajs/index@2.4.0-snapshot-20250125144527
yarn add @medusajs/inventory@2.4.0-snapshot-20250125144527
yarn add @medusajs/link-modules@2.4.0-snapshot-20250125144527
yarn add @medusajs/locking@2.4.0-snapshot-20250125144527
yarn add @medusajs/notification@2.4.0-snapshot-20250125144527
yarn add @medusajs/order@2.4.0-snapshot-20250125144527
yarn add @medusajs/payment@2.4.0-snapshot-20250125144527
yarn add @medusajs/pricing@2.4.0-snapshot-20250125144527
yarn add @medusajs/product@2.4.0-snapshot-20250125144527
yarn add @medusajs/promotion@2.4.0-snapshot-20250125144527
yarn add @medusajs/auth-emailpass@2.4.0-snapshot-20250125144527
yarn add @medusajs/auth-github@2.4.0-snapshot-20250125144527
yarn add @medusajs/auth-google@2.4.0-snapshot-20250125144527
yarn add @medusajs/file-local@2.4.0-snapshot-20250125144527
yarn add @medusajs/file-s3@2.4.0-snapshot-20250125144527
yarn add @medusajs/fulfillment-manual@2.4.0-snapshot-20250125144527
yarn add @medusajs/locking-postgres@2.4.0-snapshot-20250125144527
yarn add @medusajs/locking-redis@2.4.0-snapshot-20250125144527
yarn add @medusajs/notification-local@2.4.0-snapshot-20250125144527
yarn add @medusajs/notification-sendgrid@2.4.0-snapshot-20250125144527
yarn add @medusajs/payment-stripe@2.4.0-snapshot-20250125144527
yarn add @medusajs/region@2.4.0-snapshot-20250125144527
yarn add @medusajs/sales-channel@2.4.0-snapshot-20250125144527
yarn add @medusajs/stock-location@2.4.0-snapshot-20250125144527
yarn add @medusajs/store@2.4.0-snapshot-20250125144527
yarn add @medusajs/tax@2.4.0-snapshot-20250125144527
yarn add @medusajs/user@2.4.0-snapshot-20250125144527
yarn add @medusajs/workflow-engine-inmemory@2.4.0-snapshot-20250125144527
yarn add @medusajs/workflow-engine-redis@2.4.0-snapshot-20250125144527

Latest commit: f803157

Copy link
Contributor

kodiakhq bot commented Jan 28, 2025

This PR currently has a merge conflict. Please resolve this and then re-add the automerge label.

@kodiakhq kodiakhq bot removed the automerge label Jan 28, 2025
Copy link
Contributor

@kasperkristensen kasperkristensen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also update the HTTP types? 😄

@riqwan
Copy link
Contributor Author

riqwan commented Jan 28, 2025

good point, added @kasperkristensen! 💪🏻

@kodiakhq kodiakhq bot merged commit 8af4fb0 into develop Jan 28, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/variant-sku-query branch January 28, 2025 10:26
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants