Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add tasks orchestrator #11161

Merged
merged 5 commits into from
Jan 27, 2025
Merged

feat: Add tasks orchestrator #11161

merged 5 commits into from
Jan 27, 2025

Conversation

thetutlage
Copy link
Contributor

Fixes: FRMW-2885

Copy link

vercel bot commented Jan 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 27, 2025 0:29am
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Jan 27, 2025 0:29am
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:29am
docs-ui ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:29am
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:29am
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:29am
resources-docs ⬜️ Ignored (Inspect) Visit Preview Jan 27, 2025 0:29am

Copy link

changeset-bot bot commented Jan 27, 2025

⚠️ No Changeset found

Latest commit: 95a31f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

we only need a public renewLock(entity) method.

@adrien2p
Copy link
Member

LGTM

we only need a public renewLock(entity) method.

The acquire lock already expand the lock timeout for a given owner id if it already exists (based on the LUA scripts at least 😅 ). Eventually we could make the acquire method public and it would do that but you think it should be handled at a higher level?

@kodiakhq kodiakhq bot merged commit 10962a5 into develop Jan 27, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/index-engine-orchestrator branch January 27, 2025 12:43
jimrarras pushed a commit to jimrarras/medusa that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants