Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows, dashboard, medusa, types): optional shipping profile #11434

Merged
merged 9 commits into from
Feb 17, 2025
Merged

feat(core-flows, dashboard, medusa, types): optional shipping profile #11434

merged 9 commits into from
Feb 17, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Feb 12, 2025

What

  • make shipping profile optional for products
  • update requires_shipping condition
  • add clear button for combobox

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2025 5:30pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 13, 2025 5:30pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:30pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:30pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:30pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:30pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 5:30pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 12, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8814aed

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@fPolic fPolic changed the title feat(core-flows, dashboard medusa, types): optional shipping profile feat(core-flows, dashboard, medusa, types): optional shipping profile Feb 12, 2025
@fPolic fPolic marked this pull request as ready for review February 13, 2025 11:44
@fPolic fPolic requested a review from a team as a code owner February 13, 2025 11:44
@fPolic
Merge branch 'develop' into feat/optional-shipping-profile
8814aed 
# Conflicts:
#	packages/core/core-flows/src/product/workflows/create-products.ts
@olivermrbl olivermrbl merged commit ee848bf into develop Feb 17, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl