Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core-flows, types): add has missing inventory flag when listing shipping options #11493

Merged
merged 8 commits into from
Feb 19, 2025
Merged

feat(core-flows, types): add has missing inventory flag when listing shipping options #11493

merged 8 commits into from
Feb 19, 2025

Conversation

fPolic
Copy link
Contributor

@fPolic fPolic commented Feb 17, 2025 •
edited
Loading

What

  • add insufficient_inventory flag when listing shipping options for a cart
  • add enabled_in_store flag when creating/editing pickup options

@fPolic fPolic requested a review from a team as a code owner February 17, 2025 13:59
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b741745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Feb 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 1:15pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 18, 2025 1:15pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 1:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 1:15pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 1:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 1:15pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 1:15pm

olivermrbl
olivermrbl approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment, think we can merge after it has been addressed.

olivermrbl
olivermrbl reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@olivermrbl olivermrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test too?

@kodiakhq kodiakhq bot merged commit 0c530e9 into develop Feb 19, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the feat/inventory-flag-list-options branch February 19, 2025 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olivermrbl olivermrbl olivermrbl approved these changes

@carlos-r-l-rodrigues carlos-r-l-rodrigues Awaiting requested review from carlos-r-l-rodrigues carlos-r-l-rodrigues is a code owner automatically assigned from medusajs/engineering

@kasperkristensen kasperkristensen Awaiting requested review from kasperkristensen kasperkristensen is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
automerge team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fPolic @olivermrbl