Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for idempotency key in payments #11494

Merged
merged 1 commit into from
Feb 17, 2025
Merged

feat: Add support for idempotency key in payments #11494

merged 1 commit into from
Feb 17, 2025

Conversation

sradevski
Copy link
Member

This PR makes changes to the payment module so an idempotency key is passed to the payment provider, and in cases where the payment provider supports it, it is used to guarantee idempotency of requests (eg. Stripe is one that does support idempotency keys).

CLOSES CLO-408

@sradevski sradevski requested a review from a team as a code owner February 17, 2025 14:11
@vercel Vercel
Copy link

vercel bot commented Feb 17, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api-reference 🔄 Building (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:15pm
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 17, 2025 2:15pm
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:15pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:15pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:15pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:15pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 17, 2025 2:15pm

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 86b63e7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sradevski sradevski force-pushed the feat/add-support-idempotency-key-payments branch from 57de9ac to 86b63e7 Compare February 17, 2025 14:14
@sradevski sradevski requested a review from olivermrbl February 17, 2025 14:15
@sradevski sradevski mentioned this pull request Feb 17, 2025
Open
christiananese
christiananese approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@christiananese christiananese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally! 😄

@sradevski sradevski merged commit 91d3332 into develop Feb 17, 2025
23 checks passed
@sradevski sradevski deleted the feat/add-support-idempotency-key-payments branch February 17, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christiananese christiananese christiananese approved these changes

@olivermrbl olivermrbl olivermrbl approved these changes

@sgirones sgirones Awaiting requested review from sgirones sgirones is a code owner automatically assigned from medusajs/engineering

@fPolic fPolic Awaiting requested review from fPolic fPolic is a code owner automatically assigned from medusajs/engineering

Assignees
No one assigned
Labels
team: medusa type: feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sradevski @christiananese @olivermrbl