Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): Handle 0 correctly in build query #11525

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

olivermrbl
Copy link
Contributor

@olivermrbl olivermrbl commented Feb 19, 2025

What

Remove truthy/falsy check for take and skip

Why

To ensure { take: 0, skip: 0 } is not converted to { take: undefined, skip: undefined }

Copy link

changeset-bot bot commented Feb 19, 2025

⚠️ No Changeset found

Latest commit: 98d19da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Feb 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 6:46pm
6 Skipped Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) Feb 19, 2025 6:46pm
api-reference-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 6:46pm
docs-ui ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 6:46pm
docs-v2 ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 6:46pm
medusa-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 6:46pm
resources-docs ⬜️ Ignored (Inspect) Visit Preview Feb 19, 2025 6:46pm

Copy link
Contributor

@carlos-r-l-rodrigues carlos-r-l-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the strict check !== intended, or should it be config.take != null?

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on != null

@kodiakhq kodiakhq bot merged commit dbd06fd into develop Feb 19, 2025
23 checks passed
@kodiakhq kodiakhq bot deleted the fix/build-query-pagination branch February 19, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants