fix(dashboard): Prevent overfetching data #11532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Skipped Deployments
|
🦋 Changeset detectedLatest commit: 99b6546 The changes in this PR will be included in the next version bump. This PR includes changesets to release 65 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carlos-r-l-rodrigues
approved these changes
Feb 19, 2025
kasperkristensen
approved these changes
Feb 19, 2025
|
/snapshot-this |
🚀 A snapshot release has been made for this PRTest the snapshots by updating your yarn add @medusajs/admin-bundler@2.6.0-snapshot-20250219141800yarn add @medusajs/admin-sdk@2.6.0-snapshot-20250219141800yarn add @medusajs/admin-shared@2.6.0-snapshot-20250219141800yarn add @medusajs/admin-vite-plugin@2.6.0-snapshot-20250219141800yarn add @medusajs/dashboard@2.6.0-snapshot-20250219141800yarn add create-medusa-app@2.6.0-snapshot-20250219141800yarn add @medusajs/cli@2.6.0-snapshot-20250219141800yarn add medusa-dev-cli@2.6.0-snapshot-20250219141800yarn add @medusajs/medusa-oas-cli@2.6.0-snapshot-20250219141800yarn add @medusajs/core-flows@2.6.0-snapshot-20250219141800yarn add @medusajs/framework@2.6.0-snapshot-20250219141800yarn add @medusajs/js-sdk@2.6.0-snapshot-20250219141800yarn add @medusajs/modules-sdk@2.6.0-snapshot-20250219141800yarn add @medusajs/orchestration@2.6.0-snapshot-20250219141800yarn add @medusajs/types@2.6.0-snapshot-20250219141800yarn add @medusajs/utils@2.6.0-snapshot-20250219141800yarn add @medusajs/workflows-sdk@2.6.0-snapshot-20250219141800yarn add @medusajs/icons@2.6.0-snapshot-20250219141800yarn add @medusajs/ui@4.0.6-snapshot-20250219141800yarn add @medusajs/ui-preset@2.6.0-snapshot-20250219141800yarn add @medusajs/medusa@2.6.0-snapshot-20250219141800yarn add @medusajs/telemetry@2.6.0-snapshot-20250219141800yarn add @medusajs/test-utils@2.6.0-snapshot-20250219141800yarn add @medusajs/api-key@2.6.0-snapshot-20250219141800yarn add @medusajs/auth@2.6.0-snapshot-20250219141800yarn add @medusajs/cache-inmemory@2.6.0-snapshot-20250219141800yarn add @medusajs/cache-redis@2.6.0-snapshot-20250219141800yarn add @medusajs/cart@2.6.0-snapshot-20250219141800yarn add @medusajs/currency@2.6.0-snapshot-20250219141800yarn add @medusajs/customer@2.6.0-snapshot-20250219141800yarn add @medusajs/event-bus-local@2.6.0-snapshot-20250219141800yarn add @medusajs/event-bus-redis@2.6.0-snapshot-20250219141800yarn add @medusajs/file@2.6.0-snapshot-20250219141800yarn add @medusajs/fulfillment@2.6.0-snapshot-20250219141800yarn add @medusajs/index@2.6.0-snapshot-20250219141800yarn add @medusajs/inventory@2.6.0-snapshot-20250219141800yarn add @medusajs/link-modules@2.6.0-snapshot-20250219141800yarn add @medusajs/locking@2.6.0-snapshot-20250219141800yarn add @medusajs/notification@2.6.0-snapshot-20250219141800yarn add @medusajs/order@2.6.0-snapshot-20250219141800yarn add @medusajs/payment@2.6.0-snapshot-20250219141800yarn add @medusajs/pricing@2.6.0-snapshot-20250219141800yarn add @medusajs/product@2.6.0-snapshot-20250219141800yarn add @medusajs/promotion@2.6.0-snapshot-20250219141800yarn add @medusajs/auth-emailpass@2.6.0-snapshot-20250219141800yarn add @medusajs/auth-github@2.6.0-snapshot-20250219141800yarn add @medusajs/auth-google@2.6.0-snapshot-20250219141800yarn add @medusajs/file-local@2.6.0-snapshot-20250219141800yarn add @medusajs/file-s3@2.6.0-snapshot-20250219141800yarn add @medusajs/fulfillment-manual@2.6.0-snapshot-20250219141800yarn add @medusajs/locking-postgres@2.6.0-snapshot-20250219141800yarn add @medusajs/locking-redis@2.6.0-snapshot-20250219141800yarn add @medusajs/notification-local@2.6.0-snapshot-20250219141800yarn add @medusajs/notification-sendgrid@2.6.0-snapshot-20250219141800yarn add @medusajs/payment-stripe@2.6.0-snapshot-20250219141800yarn add @medusajs/region@2.6.0-snapshot-20250219141800yarn add @medusajs/sales-channel@2.6.0-snapshot-20250219141800yarn add @medusajs/stock-location@2.6.0-snapshot-20250219141800yarn add @medusajs/store@2.6.0-snapshot-20250219141800yarn add @medusajs/tax@2.6.0-snapshot-20250219141800yarn add @medusajs/user@2.6.0-snapshot-20250219141800yarn add @medusajs/workflow-engine-inmemory@2.6.0-snapshot-20250219141800yarn add @medusajs/workflow-engine-redis@2.6.0-snapshot-20250219141800
|
kodiakhq
bot
deleted the
fix/dashboard-overfetching-data-product-variants
branch
This was referenced Feb 19, 2025
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 27, 2025
What - Remove `fields` from query to export products Why - The product export route uses the `fields` in the export request if specified. The `fields` didn't used to be part of the request, but in #11532 we accidentally started using a narrow set of fields as a result of shaving down on the requested data elsewhere in the dashboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Currently, the dashboard is fetching way more data than needed to display the products. This can lead to issues for complex catalog. this pr aim to reduce the data to be fetched to exactly what is needed.