Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(excluded_filetypes): Add property to exclude filetypes in which … #1

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

brunnseb
Copy link

@brunnseb brunnseb commented Nov 7, 2024

Add possibility to exclude certain filetypes from auto_suggestion being run. Manual suggestion still works as before.

Copy link
Owner

@meeehdi-dev meeehdi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @brunnseb ,

Thank you for your contribution 🙏

The change looks good as is, but i think we can optimize the util function in case someone decides to have a huge array of excluded types.

@brunnseb
Copy link
Author

brunnseb commented Nov 8, 2024

hi @brunnseb ,

Thank you for your contribution 🙏

The change looks good as is, but i think we can optimize the util function in case someone decides to have a huge array of excluded types.

Makes sense, I updated the contains helper accordingly

@brunnseb brunnseb requested a review from meeehdi-dev November 8, 2024 10:13
Copy link
Owner

@meeehdi-dev meeehdi-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🫶

@meeehdi-dev meeehdi-dev merged commit 0ad45f6 into meeehdi-dev:main Nov 8, 2024
meeehdi-dev added a commit that referenced this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants