Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: image upload button does not work - refresh models list persist current selected engine #4768

Merged
merged 1 commit into from
Mar 3, 2025
Merged

fix: image upload button does not work - refresh models list persist current selected engine #4768

merged 1 commit into from
Mar 3, 2025
+30 −27

Conversation

louis-menlo
Copy link
Contributor

This pull request includes changes to improve the consistency and clarity of the codebase by standardizing the naming of the engine parameter across multiple files. The most important changes include updating the useRefreshModelList hook, modifying the RemoteModelRefresh component, and adjusting the RemoteEngineSettings component.

Standardization of engine parameter:

Minor UI adjustment:

  • web/screens/Hub/index.tsx: Moved the getRootProps spread operator to the correct position within the JSX structure for better readability.

@github-actions github-actions bot added the type: bug Something isn't working label Mar 2, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 2, 2025

Barecheck - Code coverage report

Total: 67.74%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/hooks/useEngineManagement.ts47-48, 50, 71, 84-85, 87, 97, 100, 102, 110, 117-118, 120, 130, 132, 139, 148, 153, 155, 161, 163, 165-168, 172-173, 176-177, 180, 191, 204, 208, 210, 216, 218-220, 222, 226-227, 230-231, 234, 243, 254-255, 257, 265, 268-269, 277, 281, 293, 295-296, 299, 301-302, 304-305, 318, 320-321, 324, 326-328, 330-331, 343, 345-346, 349, 351-353, 355-356, 365, 367-368, 371, 373-375, 377-378, 390, 392-393, 396, 398-400, 402-403, 414, 416-417, 420, 422, 427-428, 430-431, 440-441, 443, 445, 448, 451, 455, 477-478, 480, 482-483, 485, 487, 493, 498

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 3, 2025

This is the build for this pull request. You can download it from the Artifacts section here: Build URL.

@louis-menlo louis-menlo merged commit 889ab95 into dev Mar 3, 2025
21 checks passed
@louis-menlo louis-menlo deleted the fix/upload-image-button-does-not-work branch March 3, 2025 04:38
@github-actions github-actions bot added this to the v0.5.17 milestone Mar 3, 2025
@david-menloai david-menloai mentioned this pull request Mar 23, 2025
Closed
6 tasks
louis-menlo added a commit that referenced this pull request Mar 24, 2025
@louis-menlo @eckartal
@urmauur @imtuyethan @ddri @Minh141120 @david-menloai @matthewbcool
chore: sync Release/v0.5.16 into main (#4834)
91a1fb5 
* feat: Jan Hub Revamp (#4491)

* feat: model hub revamp UI

* chore: model description - consistent markdown css

* chore: add model versions dropdown

* chore: integrate APIs - model sources

* chore: update model display name

* chore: lint fix

* chore: page transition animation

* feat: model search dropdown - deeplink

* chore: bump cortex version

* chore: add remote model sources

* chore: model download state

* chore: fix model metadata label

* chore: polish model detail page markdown

* test: fix test cases

* chore: initialize default Hub model sources

* chore: fix model stats

* chore: clean up click outside and inside hooks

* feat: change hub banner

* chore: lint fix

* chore: fix css long model id

* chore: sync cortex engine version (#4536)

* chore: rotate model hub banner on app launch until set (#4542)

* blog: add DeepSeek R1 local installation guide (#4552)

* docs: add DeepSeek R1 local installation guide

- Add comprehensive guide for running DeepSeek R1 locally
- Include step-by-step instructions with screenshots
- Add VRAM requirements and model selection guide
- Include system prompt setup instructions

* docs: add comprehensive guide on running AI models locally

* docs: address PR feedback for DeepSeek R1 and local AI guides

- Improve language and terminology throughout
- Add Linux support information
- Enhance technical explanations
- Update introduction for better flow
- Fix parameters section in run-ai-models-locally.mdx

---------

Co-authored-by: Louis <louis@jan.ai>

* enhancement: code snippet color and bakground should depend on native theme (#4566)

* chore: correct conversational PATCH methods with latest cortex update (#4568)

* fix: exclude yml into totaldownload start next version (#4572)

* enhancement: adjust hub ui in different themes (#4574)

* enhancement: toggle change cover hub banner style (#4579)

* chore: update style codeblock (#4599)

* docs: improve local AI guides content and linking (#4600)

* docs: add DeepSeek R1 local installation guide

- Add comprehensive guide for running DeepSeek R1 locally
- Include step-by-step instructions with screenshots
- Add VRAM requirements and model selection guide
- Include system prompt setup instructions

* docs: add comprehensive guide on running AI models locally

* docs: address PR feedback for DeepSeek R1 and local AI guides

- Improve language and terminology throughout
- Add Linux support information
- Enhance technical explanations
- Update introduction for better flow
- Fix parameters section in run-ai-models-locally.mdx

* docs: improve local AI guides content and linking

- Update titles and introductions for better SEO
- Add opinionated guidance section for beginners
- Link DeepSeek guide with general local AI guide
- Fix typos and improve readability

* fix: remove git conflict markers from deepseek guide frontmatter

---------

Co-authored-by: Louis <louis@jan.ai>

* chore: open URL from model detail page should open in an external browser (#4611)

* chore: open URL from model detail page should open in an external browser

* chore: remove unused param

* Added guide for cloud model installation

* Added DeepSeek & Google guides, updated some images

* blog: improve local AI guide for beginners (#4610)

* docs: add DeepSeek R1 local installation guide

- Add comprehensive guide for running DeepSeek R1 locally
- Include step-by-step instructions with screenshots
- Add VRAM requirements and model selection guide
- Include system prompt setup instructions

* docs: add comprehensive guide on running AI models locally

* docs: address PR feedback for DeepSeek R1 and local AI guides

- Improve language and terminology throughout
- Add Linux support information
- Enhance technical explanations
- Update introduction for better flow
- Fix parameters section in run-ai-models-locally.mdx

* docs: improve local AI guides content and linking

- Update titles and introductions for better SEO
- Add opinionated guidance section for beginners
- Link DeepSeek guide with general local AI guide
- Fix typos and improve readability

* fix: remove git conflict markers from deepseek guide frontmatter

* docs: improve local AI guide for beginners

Key improvements:
- Add detailed explanation of GGUF and why it's needed
- Improve content structure and readability
- Add visual guides with SEO-friendly images
- Enhance llama.cpp explanation with GitHub link
- Fix heading hierarchy for better navigation
- Add practical examples and common questions
- Update image paths and captions for better SEO

Technical details:
- Add proper image alt text and captions
- Link to llama.cpp GitHub repository
- Clarify model size requirements
- Simplify hardware requirements section
- Improve heading structure (h1-h5)
- Add step-by-step model installation guide

* docs: add offline ChatGPT alternative guide with Jan

- Add comprehensive guide on using Jan as offline ChatGPT alternative
- Include step-by-step instructions for setup
- Add images for document chat feature
- Optimize content for SEO with relevant keywords

* docs: update description to emphasize computer-local aspect

---------

Co-authored-by: Louis <louis@jan.ai>

* docs: add new changelog posts and images (#4601)

* docs: add DeepSeek R1 local installation guide

- Add comprehensive guide for running DeepSeek R1 locally
- Include step-by-step instructions with screenshots
- Add VRAM requirements and model selection guide
- Include system prompt setup instructions

* docs: add comprehensive guide on running AI models locally

* docs: address PR feedback for DeepSeek R1 and local AI guides

- Improve language and terminology throughout
- Add Linux support information
- Enhance technical explanations
- Update introduction for better flow
- Fix parameters section in run-ai-models-locally.mdx

* docs: improve local AI guides content and linking

- Update titles and introductions for better SEO
- Add opinionated guidance section for beginners
- Link DeepSeek guide with general local AI guide
- Fix typos and improve readability

* docs: add new changelog posts and images

- Add DeepSeek R1 changelog (v0.5.14)
- Add key issues resolved changelog (v0.5.13)
- Add corresponding changelog images

---------

Co-authored-by: Louis <louis@jan.ai>

* Fix typo for Red Hat company name (#4637)

"Red Hat" is the correct company name, not "Redhat".

* feat: app updater with changelog (#4631)

* feat: ui modal app updater with changelog

* chore: update action when click update now

* chore: update handler actions

* chore: fix linter

* Update all images & some wrong parts

* chore: typo

* chore: lint fix

* fix: format compact number utils (#4695)

* chore: Hub UI and markdown CSS

* feat: allow users to refresh cloud model list (#4698)

* feat: allow users to refresh cloud model list

* chore: reusable model list refresh

* chore: clean up

* refactor: different Jan builds should have different Cortex server port (#4699)

* refactor: different Jan instances should have different Cortex server port configurations

* chore: update workflow to use env input

* chore: update env for cortex port setting

* chore: change app logo for jan beta and nightly version

* feat: Jan Model Hub should stay updated. (#4707)

* feat: Jan Model Hub should stay updated.

* chore: polish provider description

* feat: preserve token speed in the thread (#4711)

* feat: preserve token speed in the thread

* chore: lint fix

* chore: streaming should be turned on by default (#4712)

* fix: should disable start model button when there is a model is loading (#4713)

* chore: update pipeline change app logo for build nightly (#4709)

* chore: change app logo for build nightly

* chore: add nightly option to rename icons

* chore: add rename icons for nightly and beta build

* chore: remove rename icons job

* feat: Jan Model Hub filter options and responsiveness (#4714)

* feat: Jan Model Hub filter options and responsiveness

* chore: fix display unit

* chore: fix optional wrapping

* chore: correct joi component's test

* chore: sticky model hub filter panel (#4715)

* chore: migrate engine settings on update (#4719)

* chore: migrate engine settings on update

* chore: queue engine migration to ensure it only execute when server is on

* chore: ensure queue is empty instead of running in the queue

* enhancement: update pexelated icon on windows platform (#4721)

* chore: fix model hub sorting (#4722)

* chore: fix model hub sorting

* chore: linter fix

* fix: should not select vulkan by default when there are Nvidia GPUs detected (#4720)

* chore: enhance onboarding screen's models (#4723)

* chore: enhance onboarding screen's models

* chore: lint fix

* chore: correct lint fix command

* chore: fix tests

* enhancement: scrollbar setting options (#4726)

* enhancement: scrollbar setting options

* chore: fix linter

* refactor: clean up legacy predefined models (#4730)

* refactor: clean up legacy predefined models

* chore: fix onboarding filtered models

* chore: correct channel name to ask for help

* fix: flow app updater manual check from native menu (#4731)

* chore: update hub UI  (#4734)

* chore: update hub ui based feedback

* chore: update hub ui

* chore: code block ui

* chore: update bg color

* chore: decrease margin codeblock

* enhancement: improve chat thread (#4736)

* enhancement: improve chat thread

* chore: fix linter

* fix: linter

* chore: fix linter

* fix: chore failed test

* fix: chat body scrollbar (#4737)

* fix: chat body scrollbar

* chore: update lock file

* fix: remove PluggableList

* fix: onboarding screen should show persisted cloud providers (#4738)

* chore: remove hard coded recommendation models and use cortexso featured tags (#4741)

* chore: remove hard coded recommendation models and use cortexso featured tags

* chore: polish model detail page

* chore: fix test

* fix: hub ui no result search found (#4739)

* fix: hub button download  (#4742)

* fix: hub button download and use

* chore: fix linter

* fix: remove the button download on top of model page

* enhancement: receommended label engine variant (#4740)

* fix: correct default engine variant setup on first launch (#4747)

* fix: there is a case where app selects incorrect engine variant first launch

* refactor: clean up legacy settings hook

* fix: cannot click dropdown appearance (#4750)

* fix: app check available update (#4751)

* fix: some endpoints are invisible (#4752)

* chore: correct model author with new cortexso update (#4754)

* chore: hub UI tooltip filter, max model size and search result (#4753)

* chore: fix hub ui tooltip, max-filter, and search result

* chore: fix linter

* fix: deeplink does not work sometime (#4755)

* fix: deep link does not work sometime and reduce redundant request

* chore: bump cortex fix

* typo fix (#4748)

* chore: handle list number and disc readme hgf (#4756)

* chore: handle list number and disc readme hgf

* chore: fix space hover message toolbar

* chore: handle reset state filter hub revamp

* fix: Jan Quick Ask window capture input issues (#4758)

* fix: first message padding is off

* fix: correct jan discord channel

* feat: add openai 4.5 preview and anthropic claude 3.7 sonnet models

* fix: image upload button does not work - refresh models list persist current selected engine (#4768)

* fix: list space styled and hidden message toolbar when editmode (#4773)

* refactor: clean up deprecated components and events (#4769)

* fix: quickask ui color and alignment on mymodel list (#4774)

* fix: quickask ui color and alignment on mymodel list

* fix: color scheme quickask

* chore: bump cortex version to fix model sources issue (#4775)

* chore: sync initial hub models (#4778)

* chore: sync initial hub models

* fix: openai request template

* fix: naming nightly and beta build (#4779)

* fix: naming nightly and beta build

* chore: enhance replace icons for beta and nightly build logic

* chore: update icon linux build

* chore: add debug step

* chore: remove specific icon linux build

* refactor: clean up legacy vision model settings (#4777)

* analytics: integrate posthog into Jan web (#4788)

* fix: engine version update - cortex version bump - update tests (#4787)

* fix: anthropic response template correction

* fix: image preview overlap toolbar message (#4790)

* fix: cohere response template correction for proper markdown parsing

* fix: hub UI issue render readme

* chore: fix linter

* fix: result search scrollable

* fix: app image - could not load model

* chore: bump cortex version (#4793)

* enhancement: add checkmark selected model

* fix: render desc hub model list

* chore linter

* fix: table markdown

* chore: do not symlink engine on linux

* fix: update career url

* chore: correct cohere response template

* chore: bump llama.cpp to support gemma3

* fix: minor ui issue

* fix: scroll setting preferences

* chore: fix padding

* fix: clear logs should not delete the folder (#4806)

* chore: bump cortex 1.0.11-rc10

* chore: bump to latest cortex release

* feat: Cortex API Authorization

* chore: correct CI CD repo name

* chore: correct new menloresearch repo name

* feat: rotate api token for each run (#4820)

* feat: rotate api token for each run

* chore: correct github repo url

* chore: correct github api url

* chore: should not filter out models first launch

* chore: bump cortex release

* chore: should get hardware information on launch (#4821)

* chore: should have an option to not revalidate hardware information

* chore: cortex.cpp gpu activation could cause a race condition (#4825)

* fix: jan beta logo displayed in jan release (#4828)

---------

Co-authored-by: Emre Can Kartal <159995642+eckartal@users.noreply.github.com>
Co-authored-by: Faisal Amir <urmauur@gmail.com>
Co-authored-by: Ashley <tuyethantt@gmail.com>
Co-authored-by: Ashley <89722390+imtuyethan@users.noreply.github.com>
Co-authored-by: ddri <davedri@gmail.com>
Co-authored-by: Minh141120 <minh.itptit@gmail.com>
Co-authored-by: Nguyen Ngoc Minh <91668012+Minh141120@users.noreply.github.com>
Co-authored-by: Minh <david@menlo.ai>
Co-authored-by: David <davidpt.janai@gmail.com>
Co-authored-by: Matt <matthewbcool@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urmauur urmauur urmauur approved these changes

@david-menloai david-menloai Awaiting requested review from david-menloai

Assignees

@louis-menlo louis-menlo

Labels
type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louis-menlo @urmauur