Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: add checkmark selected model #4795

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

urmauur
Copy link
Member

@urmauur urmauur commented Mar 11, 2025

Describe Your Changes

This pull request includes changes to the ModelDropdown component in the web/containers/ModelDropdown/index.tsx file to enhance its functionality and user interface. The most important changes are:

Enhancements to ModelDropdown component:

  • Added CheckIcon import to the list of icons used in the component.
  • Included a conditional rendering of the CheckIcon next to the selected model to visually indicate the currently selected model.

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

@urmauur urmauur added the type: enhancement Improves a current feature label Mar 11, 2025
@urmauur urmauur added this to the v0.5.16 milestone Mar 11, 2025
@urmauur urmauur requested a review from louis-menlo March 11, 2025 07:53
@urmauur urmauur self-assigned this Mar 11, 2025
Copy link
Contributor

Barecheck - Code coverage report

Total: 67.57%

Your code coverage diff: 0.00% ▴

Uncovered files and lines
FileLines
web/containers/ModelDropdown/index.tsx129-130, 140, 149, 153, 155, 157-158, 160-161, 163-166, 168, 190-191, 201, 205, 220-221, 228-232, 234, 236, 255, 258, 265, 272, 275-276, 298, 322, 345, 366, 375, 381, 392, 395, 397, 401, 403-408, 411, 414, 471-472, 474, 500, 507, 511, 536, 541-542, 544, 548-550, 552-553, 567, 571-573, 610, 618, 620

@urmauur urmauur merged commit cce52f0 into dev Mar 11, 2025
13 of 16 checks passed
@urmauur urmauur deleted the enhancement/selected-model branch March 11, 2025 14:26
@david-menloai david-menloai mentioned this pull request Mar 23, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improves a current feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enhancement: improve the way to display the selecting model
2 participants