Wrapping guid.NewV4() to get prior behavior returning a single value. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, the go.uuid library was modified to return a string, and an error when generating UUIDs. See [1]. For backwards compatibility, a Must func helper is provided which panics if there are any errors, reovering the prior behavior. [1] satori/go.uuid@0ef6afb#diff-18f04d9ad3369192f1154eb2a981af41
pascallouisperez
added a commit
to homelight/worksheets
that referenced
this pull request
Jan 8, 2018
Recently [1], satori/go.uuid changed the signature of various functions, including NewV4 used by sqlx runner. As a result, sqlx runner does not compile at HEAD anymore. A change was submitted to sqlx runner [2], but meanwhile, to keep our build green, we're forcibly setting the satory/go.uuid version to a specific sha. This approach is chosen over vendoring since the intent of worksheets is to be used as a library in a project which would itself manage vendoring. [1] satori/go.uuid@0ef6afb [2] mgutz/dat#77
pascallouisperez
added a commit
to homelight/worksheets
that referenced
this pull request
Jan 8, 2018
Recently [1], satori/go.uuid changed the signature of various functions, including NewV4 used by sqlx runner. As a result, sqlx runner does not compile at HEAD anymore. A change was submitted to sqlx runner [2], but meanwhile, to keep our build green, we're forcibly setting the satory/go.uuid version to a specific sha. This approach is chosen over vendoring since the intent of worksheets is to be used as a library in a project which would itself manage vendoring. [1] satori/go.uuid@0ef6afb [2] mgutz/dat#77
|
Hey @mgutz, can you review? |
|
Ping @mgutz! |
|
@mgutz - Please accept this PR. While I love dat, failing to accept this PR breaks builds. (Hopefully the dep versioning coming will help us..) If this is no longer being maintained, please notify so someone may fork and continue your great work. |
|
We ended up forking given the lack of response. See https://github.com/helloeave/dat cc @xorith Thanks @cbelsole for doing all the leg work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, the go.uuid library was modified to return a string, and an error when generating UUIDs. See [1]. For backwards compatibility, a Must func helper is provided which panics if there are any errors, reovering the prior behavior.
[1] satori/go.uuid@0ef6afb