Skip to content

fix: resolve test failures in Node 20+ and below Node 17 #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2025

Conversation

Suntgr
Copy link
Contributor

@Suntgr Suntgr commented Feb 15, 2025

Node.js 22 enforces stricter protection on global object properties.

The original code attempted to modify the navigator property, which is read-only in newer versions.

Using Object.defineProperty correctly sets the property descriptor, making it writable.

Copy link

vercel bot commented Feb 15, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-json-view ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 15, 2025 6:55am

@Kikobeats
Copy link
Member

Thanks a lot!

@Kikobeats Kikobeats merged commit 4c45679 into microlinkhq:master Feb 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants