Dev/annagrin/make not null #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
June 15, 2018 10:24
Introduction of explicit not_null constructor made it cumbersome to create not_nulls in c++14. Adding make_not_null helper. Usage (see tests): int i = 42; auto x = make_not_null(&i); helper(make_not_null(&i)); helper_const(make_not_null(&i));
include/gsl/pointers
Outdated
| @@ -119,6 +119,11 @@ private: | |||
| T ptr_; | |||
| }; | |||
|
|
|||
| template <class T> | |||
| auto make_not_null(T&&t) { | |||
There was a problem hiding this comment.
maybe run clang-format? T&&t looks funny to me.
include/gsl/pointers
Outdated
| @@ -119,6 +119,11 @@ private: | |||
| T ptr_; | |||
| }; | |||
|
|
|||
| template <class T> | |||
| auto make_not_null(T&&t) { | |||
| return gsl::not_null<std::remove_cv_t<std::remove_reference_t<T>>>{t}; | |||
There was a problem hiding this comment.
If the purpose of make_not_null is just to forward to the not_null constructor, isn't std::forward the right thing to use here instead?
There was a problem hiding this comment.
Nice addition, thanks.
And I agree with @neilmacintosh, should it be
template <class T>
auto make_not_null(T&&t) {
return gsl::not_null<std::remove_cv_t<std::remove_reference_t<T>>>{std::forward<T>(t)};
}
…agrin/make_not_null
|
I have tested your PR in my code with gcc 8.2.0 and clang 5.0.2. Works fine. Thanks. It helps a lot. |
|
Thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following suggestion from @kivadiu, added
make_not_nullhelper to create anot_nullIntroduction of explicit
not_nullconstructor made it cumbersome to createnot_nulls, especially in before c++17. Addingmake_not_nullhelper. Usage (see tests):See #699