Release 2.19.1 #381
Merged
Release 2.19.1 #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR does a few things: 1. Fix broken get theme test 2. Remove noisy unnecessary logs 3. Remove unused headless chrome browser when [kjhtml reporter](https://www.npmjs.com/package/karma-jasmine-html-reporter) is used (using a headless browser for UI debugging doesn't make sense) 4. Fix test failures not leading to Azure DevOps build pipeline failure (align with [official documentation](http://karma-runner.github.io/6.3/dev/public-api.html)) 5. Add JUnit test results reported so that Azure DevOps can report test failures nicely (base don front end implementation) You can see JUnit yourselves by going to the failed build and clicking on the tests tab like you do in the front end or backend but here is a picture 
…ject, avoid name collision Modify window.powerbi object, in order to avoid name collision Related work items: #619441
Add multi-iframe support Front end was changed to be backward compatible !209445
Remove karma-coverage dependency because it causes build pipeline to fail and doesn't add enough value. 
Auto licensing succeeded event - adding "info" event to the list of allowed events
Remove `accessToken` from the config when throwing an exception. ### Notes for reviewers - Spread operator seems to be [well supported](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax), doesn't work in IE however it was transplied to `__assign` in JS Code - I can't put it in `utils.ts` because that would create a circular dependency (with `embed.ts` due to type imports).
Build with latest Windows version and VS 2019 actions/runner-images#4312 Same changes as !231657
ghost
requested a review
from 
ali-hamud
approved these changes
Feb 21, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.