Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM64] ColorPicker #17844

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Conversation

snickler
Copy link
Collaborator

Summary of the Pull Request

What is this about:
This PR enables the ColorPicker to be built for and target Arm64.

What is included in the PR:
image

How does someone test / validate:
Build ColorPickerUI in Release|ARM64 configuration. Run project and invoke with Win+Shift+C

image

Quality Checklist

  • Linked issue: Support ARM platform #490
  • Communication: I've discussed this with core contributors in the issue.
  • Tests: Added/updated and all pass
  • Installer: Added/updated and all pass
  • Localization: All end user facing strings can be localized
  • Docs: Added/ updated
  • Binaries: Any new files are added to WXS / YML

Contributor License Agreement (CLA)

A CLA must be signed. If not, go over here and sign the CLA.

Sorry, something went wrong.

@stefansjfw
Copy link
Collaborator

so cool! sooo cool!

Copy link
Collaborator

@jaimecbernardo jaimecbernardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!
Thanks a lot for the contribution!

@jaimecbernardo jaimecbernardo merged commit 2de1a51 into microsoft:main Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants