Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting floating point error on calculator #5949

Merged
merged 1 commit into from
Aug 13, 2020

Conversation

crutkas
Copy link
Member

@crutkas crutkas commented Aug 13, 2020

Summary of the Pull Request

Correcting floating point error. Same tweak that Wox has. Wonder why we didn't have it in.
https://github.com/Wox-launcher/Wox/blob/master/Plugins/Wox.Plugin.Calculator/Main.cs

PR Checklist

  • Applies to [Run, tracker] calculator (mage nuget) having calculation issues #3697
  • CLA signed. If not, go over here and sign the CLA
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

@crutkas crutkas added the Product-PowerToys Run Improved app launch PT Run (Win+R) Window label Aug 13, 2020
@crutkas crutkas requested a review from a team August 13, 2020 20:21
Copy link
Contributor

@ryanbodrug-microsoft ryanbodrug-microsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice find. I think we probably forked before this change was put in.

@crutkas crutkas merged commit e4ea8d2 into master Aug 13, 2020
@crutkas crutkas deleted the dev/crutkas/CalculatorFix branch August 13, 2020 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Product-PowerToys Run Improved app launch PT Run (Win+R) Window
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants