Skip to content

docs(i18n-id): translate disableReferencedProjectLoad.md, disableSizeLimit.md, disableSolutionSearching.md, and several config into Indonesia #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

R1dwanMaulana
Copy link
Contributor

Overview

This is part of #938

Changes

Translate the following files

  • disableReferencedProjectLoad.md
  • disableSizeLimit.md
  • disableSolutionSearching.md

…Limit.md, disableSolutionSearching.md and several config section into Indonesia
@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @AMashoshyna - if they write a comment saying "LGTM" then it will be merged.

@AMashoshyna
Copy link
Contributor

@R1dwanMaulana Hi! Looks like we have and issue with CODEOWNERS file. I was accidentally assigned to code-review Indonesian version. Opened a PR with a fix: #1161

@jefrydco @nusendra @mazipan @mandaputtra FYI

@mandaputtra
Copy link
Contributor

@R1dwanMaulana you can create pull request again after the fix get merged, for now just wait or you can open this pull request again we will check and @AMashoshyna will help us merge this translation. Thanks.

IMO better wait till fix get merged.

@R1dwanMaulana
Copy link
Contributor Author

ok

@R1dwanMaulana
Copy link
Contributor Author

still in trouble?

@AMashoshyna
Copy link
Contributor

Yep, PR still open. But I can approve the PR with "LGTM", as @mandaputtra suggested

@github-actions github-actions bot merged commit 23d08a4 into microsoft:v2 Sep 29, 2020
@github-actions
Copy link
Contributor

Merging because @AMashoshyna is a code-owner of all the changes - thanks!

@AMashoshyna
Copy link
Contributor

Omg, I'm sorry. I did not mean to actually merge the PR. Soo sorry.
FYI @jefrydco @nusendra @mazipan @mandaputtra

@mandaputtra
Copy link
Contributor

No problem @AMashoshyna 👌 I will fix it later. I guess the bot need some improvement 😆

@R1dwanMaulana
Copy link
Contributor Author

need bot repair 😅

@orta
Copy link
Contributor

orta commented Sep 29, 2020

ha - looks like we didn't add the prefixes paths here -

packages/playground-examples/copy/id @AMashoshyna [translation] [uk]
packages/tsconfig-reference/copy/id/**/*.md @AMashoshyna [translation] [uk]
packages/typescriptlang-org/src/copy/id/**/*.ts @AMashoshyna [translation] [uk]
packages/typescriptlang-org/src/copy/id.ts @AMashoshyna [translation] [uk]
packages/documentation/copy/id/**/*.md @AMashoshyna [translation] [uk]

@jefrydco
Copy link
Contributor

@orta Yup, this is the fix for that #1161

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants