-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[ja translation] tsconfig-reference 9 files #1432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR! This section of the codebase is owned by @sasurau4, @Quramy, @Naturalclar, and @Takepepe - if they write a comment saying "LGTM" then it will be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bundledPackageName.md
が原因でCIが失敗していた & TODOリストにも載っていなかったので削除
packages/tsconfig-reference/copy/ja/options/noUncheckedIndexedAccess.md
Outdated
Show resolved
Hide resolved
// ^? | ||
|
||
// 宣言されていませんが、インデックス | ||
// シグネチャのおかげで、stringとして扱われます |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これも元のドキュメントが微妙に間違っているので、PRを出してもらえると 👍
上の文書とまるっきり一緒なので、noUncheckedIndexedAccessの使い所が分からなくなってしまいました :)
// シグネチャのおかげで、stringとして扱われます | |
// シグネチャのおかげで、string | undefinedとして扱われます |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discordで聞いてみたので、それの返信を待ちましょう
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
遅くなりましたが見ました!
packages/tsconfig-reference/copy/ja/sections/watchOptions.md
がempty fileですが、ミスでしょうか?
- `fixedPollingInterval`: すべてのファイルの変更を一定間隔で毎秒数回チェックします。 | ||
- `priorityPollingInterval`: すべてのファイルの変更を毎秒数回チェックしますが、ヒューリスティックスを使用して他のファイルよりも少ない頻度で特定のタイプのファイルをチェックします。 | ||
- `dynamicPriorityPolling`: 変更頻度の低いファイルがチェックされる頻度が低くなるような動的なキューを使用します。 | ||
- `useFsEvents` (デフォルト): オペレーティングシステム/ファイルシステムのネイティブイベントの使用をファイルの変更に試みます。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上と同様
Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
レビューありがとうございます。 |
Co-authored-by: Daiki Ihara <sasurau4@gmail.com>
|
I think this PR just needs a final review? Otherwise I'll close this PR at the end of the week, because we're moving these PRs into their own repos re: #1480 |
I am not the owner of the codebase, but I think this PR has passed all reviews |
👍🏻 |
ref: #220
files:
diff: d969a42