Skip to content

Make elementToAppend take priority over domID for sandbox configs #2886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/sandbox/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const createTypeScriptSandbox = (

const language = languageType(config)
const filePath = createFileUri(config, compilerOptions, monaco)
const element = "domID" in config ? document.getElementById(config.domID) : (config as any).elementToAppend
const element = (config as any).elementToAppend ? (config as any).elementToAppend : document.getElementById(config.domID)

const model = monaco.editor.createModel(defaultText, language, filePath)
monaco.editor.defineTheme("sandbox", sandboxTheme)
Expand Down