Skip to content

Brazilian Portuguese translation #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 22, 2020
Merged

Brazilian Portuguese translation #770

merged 15 commits into from
Jul 22, 2020

Conversation

khaosdoctor
Copy link
Contributor

@khaosdoctor khaosdoctor commented Jul 14, 2020

As of #233

Will add other files here as I translate them.

@khaosdoctor khaosdoctor changed the title Portuguese translation of intro Brazilian Portuguese translation Jul 14, 2020
@khaosdoctor
Copy link
Contributor Author

CC @orta

@orta
Copy link
Contributor

orta commented Jul 16, 2020

Tested locally and it works great:

Screen Shot 2020-07-16 at 11 12 46 AM

Screen Shot 2020-07-16 at 11 13 02 AM

@khaosdoctor
Copy link
Contributor Author

khaosdoctor commented Jul 21, 2020

@orta I fixed a typo in 6f49278 in the English file, but had to fix conflicts and merge in 086a174. So, if you wan to cherry-pick the commit to v2 to fix it in the online docs, I think you'll have to do so in the merge commit (086a174)

@khaosdoctor
Copy link
Contributor Author

@orta If that's ok, you can merge this PR. I was thinking it's going to be very complex to conduct the translation if other people join me with only one PR, so I'll be opening other PRs in a "bunch-of-files"-base. Translating chunk by chunk instead of it all

@orta
Copy link
Contributor

orta commented Jul 21, 2020

I'd like another active speaker to give a review that the language in this PR feels alright (maybe @alvarocamillont ?) - then yep, totally good to go

@alvarocamillont
Copy link

That will be great!

@khaosdoctor
Copy link
Contributor Author

@alvarocamillont so, can you please review this PR? Then with your OK we merge it and make it easier for others to contribute :)

@alvarocamillont
Copy link

alvarocamillont commented Jul 21, 2020 via email

@alvarocamillont
Copy link

Hello @orta ! I'm trying to build on my local machine but it keeps giving yarn error ...
My machine is linux (Ubuntu) with node 14 and yarn 2.1.1, any tips?

@orta
Copy link
Contributor

orta commented Jul 21, 2020

is it #792 (comment) ?

@alvarocamillont
Copy link

It is not exactly that error, but it is very similar. It is in the same step in yarn install.
I am validating the text in the md file since you successfully built it. But I would like to run it locally, besides after this validation of the khaosdoctor file I want to create my PRs;)

@orta
Copy link
Contributor

orta commented Jul 21, 2020

Can you get me a log (or tell me if it's a specific dep) I'm trying to clean the tree a bit to see if I can drop them

@alvarocamillont
Copy link

Sure! Do you want me to pass this issue or the issue you indicated?

@orta
Copy link
Contributor

orta commented Jul 22, 2020

thanks folks, will merge on green!

@orta orta merged commit c0f33c9 into microsoft:v2 Jul 22, 2020
@orta
Copy link
Contributor

orta commented Jul 22, 2020

@khaosdoctor khaosdoctor deleted the pt-br-translation branch July 27, 2020 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants