Skip to content

translate(pt): Documentation home page #831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 17, 2020

Conversation

danilofuchs
Copy link
Contributor

@danilofuchs danilofuchs commented Aug 1, 2020

Documentation home page is translated to Portuguese! @orta, @khaosdoctor, @alvarocamillont

Related to #822, tracked by #233

Some notes:

  • The headline links are not internationalized. I added a TODO comment

  • Some keys are declared but unused

  • The link for Electron was invalid

  • The title of the Handbook tile was hard-coded

  • I had some to make some translation decisions/trade-offs:

    • Framework, Web, Bundler are some technical terms with no meaningful equivalent in Portuguese, so I kept them as-is
    • Zero config is not an expression we do have in Portuguese, so I tried to make some contextual translations

📄 📷

image

nav_: {
id: "foo",
defaultMessage: "foo",
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typos

@orta
Copy link
Contributor

orta commented Aug 3, 2020

( I also made some (drastic) tweaks to some of these pages over the weekend, sorry about the merge conflicts )

@khaosdoctor
Copy link
Contributor

@danilofuchs Could you review those suggestions?

@danilofuchs
Copy link
Contributor Author

@danilofuchs Could you review those suggestions?

Sure! I have had a couple of busy weeks, but I will update it shortly

@danilofuchs danilofuchs force-pushed the intl-pt-documentation branch from c930231 to e5fc272 Compare August 16, 2020 00:21
Co-authored-by: khaosdoctor <hello@lsantos.dev>
@danilofuchs
Copy link
Contributor Author

@khaosdoctor. I rebased the branch and updated the translations as suggested. Thanks!

Copy link
Contributor

@khaosdoctor khaosdoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with comments inside JSON

@khaosdoctor
Copy link
Contributor

lgtm

@danilofuchs
Copy link
Contributor Author

@orta needs to merge, as it changes some other files

@orta
Copy link
Contributor

orta commented Aug 17, 2020

Thanks!

@orta orta merged commit 7b940d1 into microsoft:v2 Aug 17, 2020
@danilofuchs danilofuchs deleted the intl-pt-documentation branch August 17, 2020 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants