-
Notifications
You must be signed in to change notification settings - Fork 1.4k
translate(pt): Documentation home page #831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nav_: { | ||
id: "foo", | ||
defaultMessage: "foo", | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typos
( I also made some (drastic) tweaks to some of these pages over the weekend, sorry about the merge conflicts ) |
@danilofuchs Could you review those suggestions? |
Sure! I have had a couple of busy weeks, but I will update it shortly |
c930231
to
e5fc272
Compare
Co-authored-by: khaosdoctor <hello@lsantos.dev>
@khaosdoctor. I rebased the branch and updated the translations as suggested. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving with comments inside JSON
lgtm |
@orta needs to merge, as it changes some other files |
Thanks! |
Documentation home page is translated to Portuguese! @orta, @khaosdoctor, @alvarocamillont
Related to #822, tracked by #233
Some notes:
The headline links are not internationalized. I added a TODO comment
Some keys are declared but unused
The link for Electron was invalid
The title of the
Handbook
tile was hard-codedI had some to make some translation decisions/trade-offs:
Framework
,Web
,Bundler
are some technical terms with no meaningful equivalent in Portuguese, so I kept them as-isZero config
is not an expression we do have in Portuguese, so I tried to make some contextual translations📄 📷