Skip to content

Remove beta navigation translation key #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 13, 2020
Merged

Remove beta navigation translation key #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions packages/typescriptlang-org/src/components/layout/TopNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const SiteNav = (props: Props) => {
const i = createInternational<typeof navCopy>(useIntl())
const IntlLink = createIntlLink(props.lang, props.allSitePage)

// This extra bit of mis-direction ensures that non-essential code runs after
// This extra bit of mis-direction ensures that non-essential code runs after
// the page is loaded
useEffect(() => {
setupStickyNavigation()
Expand Down Expand Up @@ -98,9 +98,6 @@ export const SiteNav = (props: Props) => {
</div>
</div>

{/* <div className="hide-small" id="beta-notification-menu">{i("nav_beta_notification", { a: (...chunk) => <a href="https://github.com/microsoft/TypeScript-Website/issues">{chunk}</a> })}</div> */}

{ /** Used for skip past navigation button */}
<div id="site-content" />
</header >
)
Expand Down
3 changes: 0 additions & 3 deletions packages/typescriptlang-org/src/copy/en/nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ export const navCopy = {
nav_tools: "Tools",
nav_search_placeholder: "Search Docs",
nav_search_aria: "Search the TypeScript site",
nav_beta: "Search the TypeScript site",
nav_beta_notification:
"Note: we are testing out the new v2 site over the weekend, if we have missed something you rely on please <a>file issues on microsoft/TypeScript-Website</a>.",
// let me know if you can't make this work in your lang:
// TypeScript X.Y [stable][between?]Z.Y[beta/rc]
nav_version_stable_prefix: "is now available",
Expand Down
3 changes: 0 additions & 3 deletions packages/typescriptlang-org/src/copy/es/nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,4 @@ export const navCopy = {
nav_tools: "Probar TypeScript!",
nav_search_placeholder: "Buscar en documentación",
nav_search_aria: "Búsqueda en el sitio de TypeScript",
nav_beta: "Búsqueda en el sitio de TypeScript",
nav_beta_notification:
"Nota: esta página se encuentra en la fase beta de desarrollo, no confíes en la URL y <a>reporta incidencias en microsoft/TypeScript-Website</a>",
}
2 changes: 0 additions & 2 deletions packages/typescriptlang-org/src/copy/vo/nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,4 @@ export const navCopy = {
nav_community: "Konnect",
nav_tools: "Playground",
nav_search_placeholder: "Se4rch D0cz",
nav_beta_notification:
"Note: this page is a b3ta page, don't rely on the URL and <a>file issues on microsoft/TypeScript-Website</a>",
}
3 changes: 0 additions & 3 deletions packages/typescriptlang-org/src/copy/zh/nav.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,6 @@ export const navCopy = {
nav_tools: "工具链",
nav_search_placeholder: "搜索文档",
nav_search_aria: "搜索 TypeScript 网站",
nav_beta: "搜索 TypeScript 网站",
nav_beta_notification:
"注: 这是一个 beta 测试页面，不要依赖这些 Url，并且 <a>在 microsoft/TypeScript-Website 提出问题</a>",
// let me know if you can't make this work in your lang:
// TypeScript X.Y [stable][between?]Z.Y[beta/rc]
nav_playground: "游乐场",
Expand Down